[dashboard] fix Inspect panel action displays untitled instead of panel title #177516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
ThomThomson
approved these changes
Feb 22, 2024
| expect(getPanelTitle(api)).toBe('default title'); | ||
| }); | ||
|
|
||
| test('should return default title when title is empty string', () => { |
There was a problem hiding this comment.
Good to call this out with a test!
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 22, 2024
…el title (elastic#177516) Fixes elastic#176870 PR provides a utility method for fetching title that falls back to default title when title is not provided. (cherry picked from commit c747a3b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 22, 2024
… of panel title (#177516) (#177610) # Backport This will backport the following commits from `main` to `8.13`: - [[dashboard] fix Inspect panel action displays untitled instead of panel title (#177516)](#177516) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-22T15:27:12Z","message":"[dashboard] fix Inspect panel action displays untitled instead of panel title (#177516)\n\nFixes https://github.com/elastic/kibana/issues/176870\r\n\r\nPR provides a utility method for fetching title that falls back to\r\ndefault title when title is not provided.","sha":"c747a3b35dc086bfa3b8a1cbe67e276558c9a1f4","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","Feature:Drilldowns","v8.13.0","project:embeddableRebuild","v8.14.0"],"title":"[dashboard] fix Inspect panel action displays untitled instead of panel title","number":177516,"url":"https://github.com/elastic/kibana/pull/177516","mergeCommit":{"message":"[dashboard] fix Inspect panel action displays untitled instead of panel title (#177516)\n\nFixes https://github.com/elastic/kibana/issues/176870\r\n\r\nPR provides a utility method for fetching title that falls back to\r\ndefault title when title is not provided.","sha":"c747a3b35dc086bfa3b8a1cbe67e276558c9a1f4"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177516","number":177516,"mergeCommit":{"message":"[dashboard] fix Inspect panel action displays untitled instead of panel title (#177516)\n\nFixes https://github.com/elastic/kibana/issues/176870\r\n\r\nPR provides a utility method for fetching title that falls back to\r\ndefault title when title is not provided.","sha":"c747a3b35dc086bfa3b8a1cbe67e276558c9a1f4"}}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…el title (elastic#177516) Fixes elastic#176870 PR provides a utility method for fetching title that falls back to default title when title is not provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176870
PR provides a utility method for fetching title that falls back to default title when title is not provided.