[Entity Analytics] Hopefully fix flaky tests 🤞 #177421
Conversation
| componentType === 'RiskInformationButtonIcon' | ||
| ? RiskInformationButtonIcon | ||
| : RiskInformationButtonEmpty; | ||
| describe('RiskInformationButtonEmpty', () => { |
There was a problem hiding this comment.
Updated these tests as I have removed the RiskInformationButtonIcon component
| @@ -105,29 +106,6 @@ const getCriticalityLevelTableColumns = (): Array< | |||
| export const HOST_RISK_INFO_BUTTON_CLASS = 'HostRiskInformation__button'; | |||
| export const USER_RISK_INFO_BUTTON_CLASS = 'UserRiskInformation__button'; | |||
|
|
|||
| export const RiskInformationButtonIcon = ({ riskEntity }: { riskEntity: RiskScoreEntity }) => { | |||
There was a problem hiding this comment.
I noticed this component isn't being used when grepping around so I have removed it
| @@ -36,11 +36,17 @@ interface UserRiskEntity { | |||
| export type RiskEntity = HostRiskEntity | UserRiskEntity; | |||
|
|
|||
| const RiskSummaryComponent: React.FC<RiskEntity> = ({ risk, riskEntity, originalRisk }) => { | |||
| const currentRiskScore = | |||
| let currentRiskScore = | |||
There was a problem hiding this comment.
this is hopefully the fix for enrichments.cy.ts
hop-dev
changed the title
hop-dev
changed the title
hop-dev
changed the title
| @@ -15,9 +15,22 @@ import { | |||
| RISK_DETAILS_NAV, | |||
| } from '../screens/hosts/host_risk'; | |||
|
|
|||
| export const navigateToHostRiskDetailTab = () => { | |||
| export const navigateToHostRiskDetailTab = (attempts = 3) => { | |||
There was a problem hiding this comment.
not my proudest work but I have no idea why sometimes the tab doesn't click, and I think these tests are useful so here we are
There was a problem hiding this comment.
humm, I thought this file was about the old host details, and that we should remove it?
hop-dev
added
release_note:skip
|
@elasticmachine merge upstream |
|
/ci |
x-pack/plugins/security_solution/public/entity_analytics/components/risk_summary.tsx
Outdated
Show resolved
Hide resolved
hop-dev
force-pushed
the
flaky-risk-tab-test
branch
from
2fffafd to
f188673
Compare
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
|
Latest flaky test run https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5436 |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
The CI Stats report is too large to be displayed here, check out the CI build annotation for this information. History
To update your PR or re-run it, just comment with: cc @hop-dev |
| @@ -15,9 +15,22 @@ import { | |||
| RISK_DETAILS_NAV, | |||
| } from '../screens/hosts/host_risk'; | |||
|
|
|||
| export const navigateToHostRiskDetailTab = () => { | |||
| export const navigateToHostRiskDetailTab = (attempts = 3) => { | |||
There was a problem hiding this comment.
humm, I thought this file was about the old host details, and that we should remove it?
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
2 similar comments
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
hop-dev
added
backport:skip
Summary
Closes #174860
Closes #174859
Hopefully fix some flaky tests for good.
Flaky test run 1 (50 ESS): https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5268 ✅
Flaky test run 2 (100 ESS 100 Serverless) https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5278 ✅
Flaky test run 3 100 again https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5436 ✅ (ran as a lot of time has passed)