Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Jobs with time range api test #177052

Merged

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Feb 15, 2024

Adds api tests also updates the api schema to remove the unused dateFormatTz parameter.
dateFormatTz has never been used, but it was missed as the code was originally written in js.

@jgowdyelastic jgowdyelastic self-assigned this Feb 15, 2024
@jgowdyelastic jgowdyelastic added :ml Feature:Anomaly Detection ML anomaly detection release_note:skip Skip the PR/issue when compiling release notes v8.13.0 v8.14.0 labels Feb 15, 2024
@jgowdyelastic jgowdyelastic marked this pull request as ready for review February 15, 2024 17:21
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner February 15, 2024 17:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #54 / apis Saved queries Saved queries API "before all" hook in "Saved queries API"
  • [job] [logs] Jest Tests #7 / useGetCases shows a toast error message when an error occurs in the response

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@jgowdyelastic jgowdyelastic merged commit 84a7ec0 into elastic:main Feb 20, 2024
19 checks passed
@jgowdyelastic jgowdyelastic deleted the jobs-with-time-range-api-test branch February 20, 2024 16:08
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 20, 2024
Adds api tests also updates the api schema to remove the unused
`dateFormatTz` parameter.
`dateFormatTz` has never been used, but it was missed as the code was
originally written in js.

(cherry picked from commit 84a7ec0)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 20, 2024
# Backport

This will backport the following commits from `main` to `8.13`:
- [[ML] Jobs with time range api test
(#177052)](#177052)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-20T16:08:27Z","message":"[ML]
Jobs with time range api test (#177052)\n\nAdds api tests also updates
the api schema to remove the unused\r\n`dateFormatTz`
parameter.\r\n`dateFormatTz` has never been used, but it was missed as
the code was\r\noriginally written in
js.","sha":"84a7ec0540399b167ddf56e4cad63a6426b2356a","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","Feature:Anomaly
Detection","release_note:skip","v8.13.0","v8.14.0"],"title":"[ML] Jobs
with time range api
test","number":177052,"url":"https://github.com/elastic/kibana/pull/177052","mergeCommit":{"message":"[ML]
Jobs with time range api test (#177052)\n\nAdds api tests also updates
the api schema to remove the unused\r\n`dateFormatTz`
parameter.\r\n`dateFormatTz` has never been used, but it was missed as
the code was\r\noriginally written in
js.","sha":"84a7ec0540399b167ddf56e4cad63a6426b2356a"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177052","number":177052,"mergeCommit":{"message":"[ML]
Jobs with time range api test (#177052)\n\nAdds api tests also updates
the api schema to remove the unused\r\n`dateFormatTz`
parameter.\r\n`dateFormatTz` has never been used, but it was missed as
the code was\r\noriginally written in
js.","sha":"84a7ec0540399b167ddf56e4cad63a6426b2356a"}}]}] BACKPORT-->

Co-authored-by: James Gowdy <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
Adds api tests also updates the api schema to remove the unused
`dateFormatTz` parameter.
`dateFormatTz` has never been used, but it was missed as the code was
originally written in js.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes v8.13.0 v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants