Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs Explorer] Add not found page route #177020

Merged
merged 3 commits into from
Feb 19, 2024
Merged

[Logs Explorer] Add not found page route #177020

merged 3 commits into from
Feb 19, 2024

Conversation

tonyghiani
Copy link
Contributor

📓 Summary

Closes #177014

This work adds a new route to handle unmatched paths on the observability logs explorer app router to display a Not Found prompt instead of a blank page.

Screenshot 2024-02-15 at 15 35 49

@tonyghiani tonyghiani added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team Feature:LogsExplorer Logs Explorer feature labels Feb 15, 2024
@tonyghiani tonyghiani requested a review from a team as a code owner February 15, 2024 14:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityLogsExplorer 199 204 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityLogsExplorer 147.2KB 149.4KB +2.2KB
Unknown metric groups

async chunk count

id before after diff
observabilityLogsExplorer 3 5 +2

miscellaneous assets size

id before after diff
observabilityLogsExplorer 0.0B 387.0KB ⚠️ +387.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tonyghiani tonyghiani merged commit 153180b into elastic:main Feb 19, 2024
16 checks passed
@tonyghiani tonyghiani deleted the 177014-add-not-found-page-logs-explorer branch February 19, 2024 09:53
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Feb 19, 2024
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@tonyghiani @kibanamachine @fkanout
[Logs Explorer] Add not found page route (elastic#177020)
82a5aed 
## 📓 Summary

Closes elastic#177014 

This work adds a new route to handle unmatched paths on the
observability logs explorer app router to display a Not Found prompt
instead of a blank page.

<img width="3008" alt="Screenshot 2024-02-15 at 15 35 49"
src="https://github.com/elastic/kibana/assets/34506779/db9d0463-f77f-4590-9d41-850c72d4285c">

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yngrdyn yngrdyn yngrdyn approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:LogsExplorer Logs Explorer feature release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Logs Explorer] Add Not Found page route for unmatched path
6 participants
@tonyghiani @elasticmachine @apmmachine @kibana-ci @yngrdyn @kibanamachine