[ResponseOps] add parallel number arrays to task manager metric histograms #176881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
pmuellr
force-pushed
the
alerting/ro-team-151-non-histogram
branch
from
6929e32 to
ccda136
Compare
|
/ci |
1 similar comment
|
/ci |
pmuellr
added
the
ci:project-deploy-elasticsearch
|
/ci |
1 similar comment
|
/ci |
pmuellr
force-pushed
the
alerting/ro-team-151-non-histogram
branch
from
9fe23ba to
0dff653
Compare
|
/ci |
|
/ci |
1 similar comment
|
/ci |
pmuellr
added
ci:project-deploy-observability
|
/ci |
pmuellr
force-pushed
the
alerting/ro-team-151-non-histogram
branch
from
0dff653 to
f3697f3
Compare
|
/ci |
1 similar comment
|
/ci |
…grams towards: elastic/response-ops-team#151 As we've found the elasticsearch histogram mapping type to be difficult to use in practice, we're switching to an "array of numbers" approach as well. We'll eventually remove the histograms, once we ensure they aren't being used.
pmuellr
force-pushed
the
alerting/ro-team-151-non-histogram
branch
from
f3697f3 to
425a808
Compare
pmuellr
added
ci:build-cloud-image
ci:build-serverless-image
and removed
ci:project-deploy-observability
|
/ci |
pmuellr
commented
Mar 14, 2024
| @@ -23,6 +23,7 @@ export class SimpleHistogram { | |||
| private maxValue: number; | |||
| private bucketSize: number; | |||
| private histogramBuckets: Bucket[] = []; | |||
| private allValues: number[] = []; | |||
There was a problem hiding this comment.
To track the actual values, we just changed the SimpleHistogram class we use to create histogram shapes, to also track each value passed in. And add getAllValues() to return it.
pmuellr
added
Feature:Alerting
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
ymao1
approved these changes
Mar 18, 2024
pmuellr
requested review from
adcoelho and
ersin-erdal
and removed request for
adcoelho
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Canvas Sharable Runtime
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards: https://github.com/elastic/response-ops-team/issues/151
Summary
As we've found the elasticsearch histogram mapping type to be difficult to use in practice, we're switching to an "array of numbers" approach - keeping the histograms for now. We'll eventually remove the histograms, once we ensure they aren't being used.