Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fix flaky serverless tests in group 3 #176423

Merged
merged 6 commits into from
Feb 8, 2024
Merged

[Lens] Fix flaky serverless tests in group 3 #176423

merged 6 commits into from
Feb 8, 2024

Conversation

nickofthyme
Copy link
Contributor

@nickofthyme nickofthyme commented Feb 7, 2024 •
edited
Loading

Summary

Testing fix for flaky Lens serverless tests. This issue arose after #170914 where changes to the Lens page object were not applied to the duplicate serverless tests.

See https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5086

The grouping used in serverless is also collecting multiple non-serverless test groups configs and renaming them as a new group config file, but the failed test describe block is named with the original group still. A bit confusing but maybe we can correct this in the future to avoid confusion.

fixes #168985

@nickofthyme nickofthyme marked this pull request as ready for review February 7, 2024 21:15
@nickofthyme nickofthyme requested a review from a team as a code owner February 7, 2024 21:15
@nickofthyme nickofthyme added the release_note:skip Skip the PR/issue when compiling release notes label Feb 7, 2024
@nickofthyme
Copy link
Contributor Author

/ci

@nickofthyme
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stratoula
stratoula approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review only

@nickofthyme nickofthyme changed the title Fix flaky serverless tests in group2 Fix flaky serverless tests in group 3 Feb 8, 2024
@nickofthyme nickofthyme merged commit 8709754 into elastic:main Feb 8, 2024
17 checks passed
@nickofthyme nickofthyme deleted the fix-flaky-g2-tests branch February 8, 2024 15:55
@nickofthyme nickofthyme changed the title Fix flaky serverless tests in group 3 [Lens] Fix flaky serverless tests in group 3 Feb 8, 2024
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Feb 8, 2024
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@nickofthyme @CoenWarmer
[Lens] Fix flaky serverless tests in group 3 (elastic#176423)
5e1db53
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@nickofthyme @fkanout
[Lens] Fix flaky serverless tests in group 3 (elastic#176423)
1f33c0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.13.0
Projects
None yet
Milestone
No milestone
4 participants
@nickofthyme @kibana-ci @stratoula @kibanamachine