-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] Clicking the editor closes the documentation popover #176394
[ES|QL] Clicking the editor closes the documentation popover #176394
Conversation
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and now the popover closes when clicking outside. 👍
The only annoying thing I found is that, in Safari and only sometimes, when clicking on the ES|QL editor the query gets all selected rather than just set the cursor at the end/in the clicked position. But not a blocker 🚀
…#176394) ## Summary Part of elastic#166907 Fixes the problem with the eui popovers and the monaco editor. I am not sure why it is happening. I think it is due to the third party library that eui uses to detects the outside clicks. What I did to fix it: - Wrap the documentation popover in an EuiOutsideClickDetector - I force monaco editor to focus onMoyseDown ![meow](https://github.com/elastic/kibana/assets/17003240/f432608d-0801-4a68-b327-da1e8dec9f9a) This solves the problem on the documentation popover but not on the SuperDatePicker because I don't have a way to force it to close. I will ping the EUI team
…#176394) ## Summary Part of elastic#166907 Fixes the problem with the eui popovers and the monaco editor. I am not sure why it is happening. I think it is due to the third party library that eui uses to detects the outside clicks. What I did to fix it: - Wrap the documentation popover in an EuiOutsideClickDetector - I force monaco editor to focus onMoyseDown ![meow](https://github.com/elastic/kibana/assets/17003240/f432608d-0801-4a68-b327-da1e8dec9f9a) This solves the problem on the documentation popover but not on the SuperDatePicker because I don't have a way to force it to close. I will ping the EUI team
…#176394) ## Summary Part of elastic#166907 Fixes the problem with the eui popovers and the monaco editor. I am not sure why it is happening. I think it is due to the third party library that eui uses to detects the outside clicks. What I did to fix it: - Wrap the documentation popover in an EuiOutsideClickDetector - I force monaco editor to focus onMoyseDown ![meow](https://github.com/elastic/kibana/assets/17003240/f432608d-0801-4a68-b327-da1e8dec9f9a) This solves the problem on the documentation popover but not on the SuperDatePicker because I don't have a way to force it to close. I will ping the EUI team
Summary
Part of #166907
Fixes the problem with the eui popovers and the monaco editor. I am not sure why it is happening. I think it is due to the third party library that eui uses to detects the outside clicks.
What I did to fix it:
This solves the problem on the documentation popover but not on the SuperDatePicker because I don't have a way to force it to close. I will ping the EUI team