[ILM] Fix data allocation field #176292
Merged
[ILM] Fix data allocation field #176292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
ElenaStoeva
added
Feature:ILM
Team:Kibana Management
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
|
buildkite build this |
ElenaStoeva
added
ci:cloud-deploy
|
buildkite build this |
|
buildkite build this |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @ElenaStoeva |
yuliacech
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Thanks a lot for fixing this bug, @ElenaStoeva! Tested locally and on Cloud, all works as expected 👍
kibanamachine
added
v8.13.0
backport:skip
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
Fixes elastic#173764 ## Summary This PR fixes the "Custom" data allocation field in the edit IL policy form by adding a default value for the field. Before, there was no default value, so no value would be added to the request until the user changes the initial selection to another option. This explains the bug described from elastic#173764 (in v7.17) where there is only one option and the user is not able to change it to something else so the value of the only option cannot be added to the request. Now with these changes, if the user doesn't make any changes to the initially selected option, the default value would be added to the request. **How to test:** 1. Start Es with `yarn es snapshot` and Kibana with `yarn start`. 2. Go to Stack Management -> Index Lifecycle Policies and start creating a new policy. 3. Type in some name for the policy. Enable the Warm (or Cold) phase and type in some number in the "Move data into phase when" field. Click on "Advanced settings". 4. In the "Data allocation" field, select the "Custom" option. 5. Click on "Show request" and verify that the request correctly shows the `allocation` field (the "Any data node" option doesn't add anything to the request). 6. Select another option for the node attribution field and verify it is displayed in the request. Test the field on cloud by accessing the [CI cloud deployment](https://kibana-pr-176292.kb.us-west2.gcp.elastic-cloud.com:9243/) from this PR or by changing the if-condition in line 65 in `x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/data_tier_allocation_field/components/node_allocation.tsx` to `if (false)`. Now the "Any data node" option is not available. Follow the test instructions above and verify that the initially selected node attribute option is added to the request.
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
Fixes elastic#173764 ## Summary This PR fixes the "Custom" data allocation field in the edit IL policy form by adding a default value for the field. Before, there was no default value, so no value would be added to the request until the user changes the initial selection to another option. This explains the bug described from elastic#173764 (in v7.17) where there is only one option and the user is not able to change it to something else so the value of the only option cannot be added to the request. Now with these changes, if the user doesn't make any changes to the initially selected option, the default value would be added to the request. **How to test:** 1. Start Es with `yarn es snapshot` and Kibana with `yarn start`. 2. Go to Stack Management -> Index Lifecycle Policies and start creating a new policy. 3. Type in some name for the policy. Enable the Warm (or Cold) phase and type in some number in the "Move data into phase when" field. Click on "Advanced settings". 4. In the "Data allocation" field, select the "Custom" option. 5. Click on "Show request" and verify that the request correctly shows the `allocation` field (the "Any data node" option doesn't add anything to the request). 6. Select another option for the node attribution field and verify it is displayed in the request. Test the field on cloud by accessing the [CI cloud deployment](https://kibana-pr-176292.kb.us-west2.gcp.elastic-cloud.com:9243/) from this PR or by changing the if-condition in line 65 in `x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/data_tier_allocation_field/components/node_allocation.tsx` to `if (false)`. Now the "Any data node" option is not available. Follow the test instructions above and verify that the initially selected node attribute option is added to the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173764
Summary
This PR fixes the "Custom" data allocation field in the edit IL policy form by adding a default value for the field. Before, there was no default value, so no value would be added to the request until the user changes the initial selection to another option. This explains the bug described from #173764 (in v7.17) where there is only one option and the user is not able to change it to something else so the value of the only option cannot be added to the request. Now with these changes, if the user doesn't make any changes to the initially selected option, the default value would be added to the request.
How to test:
yarn es snapshotand Kibana withyarn start.allocationfield (the "Any data node" option doesn't add anything to the request).Test the field on cloud by accessing the CI cloud deployment from this PR or by changing the if-condition in line 65 in
x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/data_tier_allocation_field/components/node_allocation.tsxtoif (false). Now the "Any data node" option is not available. Follow the test instructions above and verify that the initially selected node attribute option is added to the request.