[8.13][Security Solution][Endpoint] Add beta badge to sentinel one connector cards/flyout and responder/isolation action flyouts #176228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashokaditya
added
release_note:skip
ashokaditya
force-pushed
the
task/dw-beta-badge-sentinel-one-8526
branch
from
25c66ee to
551f4ea
Compare
|
/ci |
ashokaditya
commented
Feb 7, 2024
| @@ -19,6 +19,11 @@ export const BETA = i18n.translate('xpack.securitySolution.pages.common.beta', { | |||
| defaultMessage: 'Beta', | |||
| }); | |||
|
|
|||
| export const BETA_TOOLTIP = i18n.translate('xpack.securitySolution.pages.common.beta.tooltip', { | |||
| defaultMessage: | |||
| 'This functionality is in beta and may be changed or removed completely in a future release. Elastic will work to fix any issues, but features in beta are not subject to the support SLA of official GA features.', | |||
There was a problem hiding this comment.
@caitlinbetz @dasansol92 @paul-tavares This needs an update.
There was a problem hiding this comment.
Updated it based on https://www.elastic.co/guide/en/kibana/8.12/infrastructure.html#infrastructure
ashokaditya
commented
Feb 7, 2024
Comment on lines
15
to
16
| defaultMessage: | ||
| 'This functionality is in beta and may be changed or removed completely in a future release. Elastic will work to fix any issues, but features in beta are not subject to the support SLA of official GA features.', |
There was a problem hiding this comment.
@caitlinbetz @dasansol92 @paul-tavares This needs an update.
There was a problem hiding this comment.
Updated it based on https://www.elastic.co/guide/en/kibana/8.12/infrastructure.html#infrastructure.
refs 0bfd258167ba3d8b110b1ff6c22dcdbbdb4a0272
ashokaditya
force-pushed
the
task/dw-beta-badge-sentinel-one-8526
branch
from
0b9fa11 to
41a950b
Compare
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
ashokaditya
requested review from
paul-tavares,
dasansol92 and
PhilippeOberti
and removed request for
patrykkopycinski
logeekal
approved these changes
Feb 7, 2024
x-pack/plugins/security_solution/public/flyout/document_details/isolate_host/header.test.tsx
Show resolved
Hide resolved
ashokaditya
changed the title
ersin-erdal
approved these changes
Feb 12, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @ashokaditya |
ashokaditya
added a commit
to ashokaditya/kibana
that referenced
this pull request
Feb 15, 2024
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…r cards/flyout and responder/isolation action flyouts (elastic#176228) ## Summary Replaces Technical Preview badge with a Beta badge for Sentinel One connector cards and connector form flyouts. Additionally it shows Beta badge on Responder for sentinel one alerts as well as Isolate/Release action flyouts. ### TODO/DONE - [x] Update beta badge tooltip text on all used instances - [x] beta badges on alerts flyout/responder behind feature flag ### Screens ### Connectors list flyout <img width="2054" alt="Screenshot 2024-02-05 at 2 14 12 PM" src="https://github.com/elastic/kibana/assets/1849116/8aa3215a-ebc0-4935-92fe-5d234f78e17b"> ### Sentinel one connector forms #### Create <img width="2056" alt="Screenshot 2024-02-05 at 2 14 26 PM" src="https://github.com/elastic/kibana/assets/1849116/fae12ae7-5301-4bc0-8934-3010b823ec5b"> #### Edit <img width="2054" alt="Screenshot 2024-02-05 at 2 31 04 PM" src="https://github.com/elastic/kibana/assets/1849116/637f1d01-fe59-47b4-bb8e-714dd9304c58"> #### Isolate/Release flyout forms for SentinelOne   #### Response Console for SentinelOne  ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <[email protected]>
2 tasks
paul-tavares
added a commit
to paul-tavares/kibana
that referenced
this pull request
Feb 21, 2024
paul-tavares
added a commit
that referenced
this pull request
Feb 22, 2024
…lity back to Tech Preview (from Beta) (#177488) ## Summary This PR reverts most of the changes done in #176228 : - Reverts changes to Connectors so that the Badge displayed for SentinelOne is again showing "Technical Preview" - Changes the badge displayed on the Host Isolation flyout and Responder for SentinelOne host to "Technical Preview" - Fixes #177337 IN addition, the following issue was also addressed: - Corrected `i18n` definition for response action log history ( Fixes #177185 ) _____________ ### Host isolation flyout <img width="1283" alt="image" src="https://github.com/elastic/kibana/assets/56442535/dc1f104a-9792-4aee-ae12-140489562d96"> ### Responder <img width="1272" alt="image" src="https://github.com/elastic/kibana/assets/56442535/6361008a-182f-4163-b754-92619b6c9ee1"> ### Connector <img width="638" alt="image" src="https://github.com/elastic/kibana/assets/56442535/338d03d9-b74d-479d-bfe2-d1796d1f2103"> <img width="1283" alt="image" src="https://github.com/elastic/kibana/assets/56442535/4eeeeccb-e966-4897-b97f-17696e0bd5ef">
paul-tavares
added a commit
to paul-tavares/kibana
that referenced
this pull request
Feb 22, 2024
…lity back to Tech Preview (from Beta) (elastic#177488) ## Summary This PR reverts most of the changes done in elastic#176228 : - Reverts changes to Connectors so that the Badge displayed for SentinelOne is again showing "Technical Preview" - Changes the badge displayed on the Host Isolation flyout and Responder for SentinelOne host to "Technical Preview" - Fixes elastic#177337 IN addition, the following issue was also addressed: - Corrected `i18n` definition for response action log history ( Fixes elastic#177185 ) _____________ ### Host isolation flyout <img width="1283" alt="image" src="https://github.com/elastic/kibana/assets/56442535/dc1f104a-9792-4aee-ae12-140489562d96"> ### Responder <img width="1272" alt="image" src="https://github.com/elastic/kibana/assets/56442535/6361008a-182f-4163-b754-92619b6c9ee1"> ### Connector <img width="638" alt="image" src="https://github.com/elastic/kibana/assets/56442535/338d03d9-b74d-479d-bfe2-d1796d1f2103"> <img width="1283" alt="image" src="https://github.com/elastic/kibana/assets/56442535/4eeeeccb-e966-4897-b97f-17696e0bd5ef"> (cherry picked from commit bd311f3) # Conflicts: # x-pack/plugins/stack_connectors/common/experimental_features.ts
paul-tavares
added a commit
that referenced
this pull request
Feb 23, 2024
…nctionality back to Tech Preview (from Beta) (#177488) (#177653) # Backport This will backport the following commits from `main` to `8.13`: - [[Security Solution][Endpoint] Revert Badges for SentinelOne functionality back to Tech Preview (from Beta) (#177488)](#177488) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paul Tavares","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-22T17:52:59Z","message":"[Security Solution][Endpoint] Revert Badges for SentinelOne functionality back to Tech Preview (from Beta) (#177488)\n\n## Summary\r\n\r\nThis PR reverts most of the changes done in #176228 : \r\n\r\n- Reverts changes to Connectors so that the Badge displayed for\r\nSentinelOne is again showing \"Technical Preview\"\r\n- Changes the badge displayed on the Host Isolation flyout and Responder\r\nfor SentinelOne host to \"Technical Preview\"\r\n- Fixes #177337 \r\n\r\nIN addition, the following issue was also addressed:\r\n\r\n- Corrected `i18n` definition for response action log history ( Fixes\r\n#177185 )\r\n\r\n\r\n_____________\r\n\r\n### Host isolation flyout\r\n\r\n<img width=\"1283\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/56442535/dc1f104a-9792-4aee-ae12-140489562d96\">\r\n\r\n\r\n\r\n### Responder\r\n\r\n<img width=\"1272\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/56442535/6361008a-182f-4163-b754-92619b6c9ee1\">\r\n\r\n\r\n### Connector\r\n\r\n<img width=\"638\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/56442535/338d03d9-b74d-479d-bfe2-d1796d1f2103\">\r\n\r\n\r\n<img width=\"1283\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/56442535/4eeeeccb-e966-4897-b97f-17696e0bd5ef\">","sha":"bd311f364420a3948012c183e40c2063308a6f89","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","v8.13.0","v8.14.0"],"number":177488,"url":"https://github.com/elastic/kibana/pull/177488","mergeCommit":{"message":"[Security Solution][Endpoint] Revert Badges for SentinelOne functionality back to Tech Preview (from Beta) (#177488)\n\n## Summary\r\n\r\nThis PR reverts most of the changes done in #176228 : \r\n\r\n- Reverts changes to Connectors so that the Badge displayed for\r\nSentinelOne is again showing \"Technical Preview\"\r\n- Changes the badge displayed on the Host Isolation flyout and Responder\r\nfor SentinelOne host to \"Technical Preview\"\r\n- Fixes #177337 \r\n\r\nIN addition, the following issue was also addressed:\r\n\r\n- Corrected `i18n` definition for response action log history ( Fixes\r\n#177185 )\r\n\r\n\r\n_____________\r\n\r\n### Host isolation flyout\r\n\r\n<img width=\"1283\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/56442535/dc1f104a-9792-4aee-ae12-140489562d96\">\r\n\r\n\r\n\r\n### Responder\r\n\r\n<img width=\"1272\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/56442535/6361008a-182f-4163-b754-92619b6c9ee1\">\r\n\r\n\r\n### Connector\r\n\r\n<img width=\"638\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/56442535/338d03d9-b74d-479d-bfe2-d1796d1f2103\">\r\n\r\n\r\n<img width=\"1283\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/56442535/4eeeeccb-e966-4897-b97f-17696e0bd5ef\">","sha":"bd311f364420a3948012c183e40c2063308a6f89"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177488","number":177488,"mergeCommit":{"message":"[Security Solution][Endpoint] Revert Badges for SentinelOne functionality back to Tech Preview (from Beta) (#177488)\n\n## Summary\r\n\r\nThis PR reverts most of the changes done in #176228 : \r\n\r\n- Reverts changes to Connectors so that the Badge displayed for\r\nSentinelOne is again showing \"Technical Preview\"\r\n- Changes the badge displayed on the Host Isolation flyout and Responder\r\nfor SentinelOne host to \"Technical Preview\"\r\n- Fixes #177337 \r\n\r\nIN addition, the following issue was also addressed:\r\n\r\n- Corrected `i18n` definition for response action log history ( Fixes\r\n#177185 )\r\n\r\n\r\n_____________\r\n\r\n### Host isolation flyout\r\n\r\n<img width=\"1283\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/56442535/dc1f104a-9792-4aee-ae12-140489562d96\">\r\n\r\n\r\n\r\n### Responder\r\n\r\n<img width=\"1272\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/56442535/6361008a-182f-4163-b754-92619b6c9ee1\">\r\n\r\n\r\n### Connector\r\n\r\n<img width=\"638\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/56442535/338d03d9-b74d-479d-bfe2-d1796d1f2103\">\r\n\r\n\r\n<img width=\"1283\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/56442535/4eeeeccb-e966-4897-b97f-17696e0bd5ef\">","sha":"bd311f364420a3948012c183e40c2063308a6f89"}}]}] BACKPORT-->
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…r cards/flyout and responder/isolation action flyouts (elastic#176228) ## Summary Replaces Technical Preview badge with a Beta badge for Sentinel One connector cards and connector form flyouts. Additionally it shows Beta badge on Responder for sentinel one alerts as well as Isolate/Release action flyouts. ### TODO/DONE - [x] Update beta badge tooltip text on all used instances - [x] beta badges on alerts flyout/responder behind feature flag ### Screens ### Connectors list flyout <img width="2054" alt="Screenshot 2024-02-05 at 2 14 12 PM" src="https://github.com/elastic/kibana/assets/1849116/8aa3215a-ebc0-4935-92fe-5d234f78e17b"> ### Sentinel one connector forms #### Create <img width="2056" alt="Screenshot 2024-02-05 at 2 14 26 PM" src="https://github.com/elastic/kibana/assets/1849116/fae12ae7-5301-4bc0-8934-3010b823ec5b"> #### Edit <img width="2054" alt="Screenshot 2024-02-05 at 2 31 04 PM" src="https://github.com/elastic/kibana/assets/1849116/637f1d01-fe59-47b4-bb8e-714dd9304c58"> #### Isolate/Release flyout forms for SentinelOne   #### Response Console for SentinelOne  ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <[email protected]>
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…lity back to Tech Preview (from Beta) (elastic#177488) ## Summary This PR reverts most of the changes done in elastic#176228 : - Reverts changes to Connectors so that the Badge displayed for SentinelOne is again showing "Technical Preview" - Changes the badge displayed on the Host Isolation flyout and Responder for SentinelOne host to "Technical Preview" - Fixes elastic#177337 IN addition, the following issue was also addressed: - Corrected `i18n` definition for response action log history ( Fixes elastic#177185 ) _____________ ### Host isolation flyout <img width="1283" alt="image" src="https://github.com/elastic/kibana/assets/56442535/dc1f104a-9792-4aee-ae12-140489562d96"> ### Responder <img width="1272" alt="image" src="https://github.com/elastic/kibana/assets/56442535/6361008a-182f-4163-b754-92619b6c9ee1"> ### Connector <img width="638" alt="image" src="https://github.com/elastic/kibana/assets/56442535/338d03d9-b74d-479d-bfe2-d1796d1f2103"> <img width="1283" alt="image" src="https://github.com/elastic/kibana/assets/56442535/4eeeeccb-e966-4897-b97f-17696e0bd5ef">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces Technical Preview badge with a Beta badge for Sentinel One connector cards and connector form flyouts.
Additionally it shows Beta badge on Responder for sentinel one alerts as well as Isolate/Release action flyouts.
TODO/DONE
Screens
Connectors list flyout
Sentinel one connector forms
Create
Edit
Isolate/Release flyout forms for SentinelOne
Response Console for SentinelOne
Checklist