Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Prompts the user to delete alerting rules upon the anomaly detection job deletion #176049

Merged
merged 7 commits into from
Feb 2, 2024
Merged

[ML] Prompts the user to delete alerting rules upon the anomaly detection job deletion #176049

merged 7 commits into from
Feb 2, 2024

Conversation

darnautov
Copy link
Contributor

Summary

Closes #174513

  • Adds a control to the job deletion dialog for deleting associated alerting rules
  • Update the delete Kibana endpoint with a flag to delete alerting rules
image

Checklist

@darnautov darnautov self-assigned this Feb 1, 2024
@darnautov darnautov marked this pull request as ready for review February 1, 2024 12:01
@darnautov darnautov requested a review from a team as a code owner February 1, 2024 12:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson added the Feature:Anomaly Detection ML anomaly detection label Feb 1, 2024
peteharverson
peteharverson approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM.

Just left a comment for the switch labels.

...lugins/ml/public/application/jobs/jobs_list/components/delete_job_modal/delete_job_modal.tsx Show resolved Hide resolved
@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

walterra
walterra approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just added a minor suggestion.

...lugins/ml/public/application/jobs/jobs_list/components/delete_job_modal/delete_job_modal.tsx Outdated Show resolved Hide resolved
@darnautov darnautov enabled auto-merge (squash) February 2, 2024 16:07
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.6MB 3.6MB +464.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ml 78.4KB 78.4KB +24.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit 2c89f97 into elastic:main Feb 2, 2024
17 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 2, 2024
@darnautov darnautov deleted the ml-174513-prompt-rule-deletion branch February 5, 2024 09:37
@darnautov darnautov mentioned this pull request Feb 5, 2024
Closed
11 tasks
fkanout pushed a commit to fkanout/kibana that referenced this pull request Feb 7, 2024
@darnautov @fkanout
[ML] Prompt the user to delete alerting rules upon the anomaly detect…
70968d0 
…ion job deletion (elastic#176049)

## Summary

Closes elastic#174513 

- Adds a control to the job deletion dialog for deleting associated
alerting rules
- Update the delete Kibana endpoint with a flag to delete alerting rules

<img width="1360" alt="image"
src="https://github.com/elastic/kibana/assets/5236598/3d22b9a6-9203-4583-b117-dfcd9087f373">

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@darnautov @CoenWarmer
[ML] Prompt the user to delete alerting rules upon the anomaly detect…
940cd93 
…ion job deletion (elastic#176049)

## Summary

Closes elastic#174513 

- Adds a control to the job deletion dialog for deleting associated
alerting rules
- Update the delete Kibana endpoint with a flag to delete alerting rules

<img width="1360" alt="image"
src="https://github.com/elastic/kibana/assets/5236598/3d22b9a6-9203-4583-b117-dfcd9087f373">

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
@szabosteve szabosteve changed the title [ML] Prompt the user to delete alerting rules upon the anomaly detection job deletion [ML] Prompts the user to delete alerting rules upon the anomaly detection job deletion Feb 15, 2024
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@darnautov @fkanout
[ML] Prompt the user to delete alerting rules upon the anomaly detect…
237bb45 
…ion job deletion (elastic#176049)

## Summary

Closes elastic#174513 

- Adds a control to the job deletion dialog for deleting associated
alerting rules
- Update the delete Kibana endpoint with a flag to delete alerting rules

<img width="1360" alt="image"
src="https://github.com/elastic/kibana/assets/5236598/3d22b9a6-9203-4583-b117-dfcd9087f373">

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra walterra approved these changes

Assignees

@darnautov darnautov

Labels
backport:skip This commit does not require backporting Feature:Anomaly Detection ML anomaly detection :ml release_note:enhancement Team:ML Team label for ML (also use :ml) v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Prompt the user to delete alerting rules while deleting anomaly detection jobs
6 participants
@darnautov @elasticmachine @kibana-ci @walterra @peteharverson @kibanamachine