Fix flaky tests #175965
Merged
Fix flaky tests #175965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e40pud
added
release_note:skip
|
/ci |
|
/ci |
|
/ci |
e40pud
requested review from
MadameSheema and
yctercero
and removed request for
yctercero
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
nkhristinin
approved these changes
Feb 2, 2024
|
@nkhristinin Thank for the review! I re-run flaky test runner with the max time possible which is 97. Updated links in description. |
MadameSheema
reviewed
Feb 2, 2024
| @@ -54,6 +53,7 @@ describe.skip('Alert user assignment - ESS & Serverless', { tags: ['@ess', '@ser | |||
| login(ROLES.soc_manager); | |||
| login(ROLES.detections_admin); | |||
| login(ROLES.platform_engineer); | |||
| login(); | |||
There was a problem hiding this comment.
Is this login method needed? Theoretically I believe it should not, in all the tests where the login() has been added to the before hook, we are calling on the beforeEach, loadPageAs(). As part of the implementation, that method, a login is performed so having that one sounds redundant. If it is needed, it would be nice to understand why to make sure we are not masking a possible issue :)
There was a problem hiding this comment.
Right, that's a good point! We do not really need login() here.
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @e40pud |
MadameSheema
approved these changes
Feb 6, 2024
kibanamachine
added
v8.13.0
backport:skip
This was referenced Feb 7, 2024
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Feb 7, 2024
## Summary These changes fix flaky alert assignments cypress tests: - elastic#173429 - elastic#172520 - elastic#172557 @MadameSheema mentioned that there were a lot of changes around login functionality recently which could have fixed original issues. We agreed that we will run a flaky test runner and if everything works fine we would un-skip tests and monitor them after the merge. ### Checklist Delete any items that are not applicable to this PR. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ESS 97 times](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5064) - [Serverless 97 times](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5052)
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
## Summary These changes fix flaky alert assignments cypress tests: - elastic#173429 - elastic#172520 - elastic#172557 @MadameSheema mentioned that there were a lot of changes around login functionality recently which could have fixed original issues. We agreed that we will run a flaky test runner and if everything works fine we would un-skip tests and monitor them after the merge. ### Checklist Delete any items that are not applicable to this PR. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ESS 97 times](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5064) - [Serverless 97 times](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5052)
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
## Summary These changes fix flaky alert assignments cypress tests: - elastic#173429 - elastic#172520 - elastic#172557 @MadameSheema mentioned that there were a lot of changes around login functionality recently which could have fixed original issues. We agreed that we will run a flaky test runner and if everything works fine we would un-skip tests and monitor them after the merge. ### Checklist Delete any items that are not applicable to this PR. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ESS 97 times](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5064) - [Serverless 97 times](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5052)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These changes fix flaky alert assignments cypress tests:
@MadameSheema mentioned that there were a lot of changes around login functionality recently which could have fixed original issues. We agreed that we will run a flaky test runner and if everything works fine we would un-skip tests and monitor them after the merge.
Checklist
Delete any items that are not applicable to this PR.