Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alert details page] [Custom threshold] Change title of condition charts #175865

Merged
merged 9 commits into from
Feb 7, 2024
Merged

[Alert details page] [Custom threshold] Change title of condition charts #175865

merged 9 commits into from
Feb 7, 2024

Conversation

benakansara
Copy link
Contributor

Resolves #174249

  • Updates title of condition charts on Custom threshold alert details page
  • In case chart title length is more than 120 chars, title is shortened with ... at end
  • Tooltip shows full title
Screenshot 2024-01-30 at 10 19 35 Screenshot 2024-01-30 at 10 19 49 Screenshot 2024-01-30 at 10 26 52

@benakansara benakansara added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:obs-ux-management Observability Management User Experience Team v8.13.0 labels Jan 30, 2024
@benakansara benakansara self-assigned this Jan 30, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@benakansara
Copy link
Contributor Author

/ci

@benakansara
Copy link
Contributor Author

/ci

@benakansara benakansara marked this pull request as ready for review January 30, 2024 10:57
@benakansara benakansara requested a review from a team as a code owner January 30, 2024 10:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

maryam-saeidi
maryam-saeidi reviewed Feb 1, 2024
View reviewed changes
Copy link
Member

@maryam-saeidi maryam-saeidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected:

image

Just added a question about an edge case.

...mponents/custom_threshold/components/alert_details_app_section/alert_details_app_section.tsx Outdated Show resolved Hide resolved
...mponents/custom_threshold/components/alert_details_app_section/alert_details_app_section.tsx Outdated Show resolved Hide resolved
...mponents/custom_threshold/components/alert_details_app_section/alert_details_app_section.tsx Outdated Show resolved Hide resolved
...mponents/custom_threshold/components/alert_details_app_section/alert_details_app_section.tsx Outdated Show resolved Hide resolved
...nts/custom_threshold/components/alert_details_app_section/alert_details_app_section.test.tsx Show resolved Hide resolved
maryam-saeidi
maryam-saeidi approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@maryam-saeidi maryam-saeidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

...mponents/custom_threshold/components/alert_details_app_section/alert_details_app_section.tsx Outdated
<EuiTitle size="xs">
<h4>{criterion.label || 'CUSTOM'} </h4>
</EuiTitle>
<EuiToolTip content={generateChartTitle(criterion).tooltip}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Maybe we can save the return value of generateChartTitle(criterion) once and then use tooltip and title from that variable. The current implementation goes through generating the title twice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in 63e1b56

@benakansara benakansara enabled auto-merge (squash) February 7, 2024 11:59
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 634.7KB 635.3KB +595.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @benakansara

@benakansara benakansara merged commit 8287a0a into elastic:main Feb 7, 2024
20 checks passed
fkanout pushed a commit to fkanout/kibana that referenced this pull request Feb 7, 2024
@benakansara @fkanout
[Alert details page] [Custom threshold] Change title of condition cha…
2fc0d72 
…rts (elastic#175865)

Resolves elastic#174249

- Updates title of condition charts on Custom threshold alert details
page
- In case chart title length is more than 120 chars, title is shortened
with `...` at end
- Tooltip shows full title

<img width="1254" alt="Screenshot 2024-01-30 at 10 19 35"
src="https://github.com/elastic/kibana/assets/69037875/41cfe6d5-5bd4-41f7-a91f-c2f3bd25943d">
<img width="1259" alt="Screenshot 2024-01-30 at 10 19 49"
src="https://github.com/elastic/kibana/assets/69037875/a9d76bf5-7f94-445e-98bf-e3763d03bdb3">
<img width="1272" alt="Screenshot 2024-01-30 at 10 26 52"
src="https://github.com/elastic/kibana/assets/69037875/642153b1-a8c2-4992-b3fd-187ffe385ca2">
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@benakansara @CoenWarmer
[Alert details page] [Custom threshold] Change title of condition cha…
5e42b31 
…rts (elastic#175865)

Resolves elastic#174249

- Updates title of condition charts on Custom threshold alert details
page
- In case chart title length is more than 120 chars, title is shortened
with `...` at end
- Tooltip shows full title

<img width="1254" alt="Screenshot 2024-01-30 at 10 19 35"
src="https://github.com/elastic/kibana/assets/69037875/41cfe6d5-5bd4-41f7-a91f-c2f3bd25943d">
<img width="1259" alt="Screenshot 2024-01-30 at 10 19 49"
src="https://github.com/elastic/kibana/assets/69037875/a9d76bf5-7f94-445e-98bf-e3763d03bdb3">
<img width="1272" alt="Screenshot 2024-01-30 at 10 26 52"
src="https://github.com/elastic/kibana/assets/69037875/642153b1-a8c2-4992-b3fd-187ffe385ca2">
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@benakansara @fkanout
[Alert details page] [Custom threshold] Change title of condition cha…
94d1334 
…rts (elastic#175865)

Resolves elastic#174249

- Updates title of condition charts on Custom threshold alert details
page
- In case chart title length is more than 120 chars, title is shortened
with `...` at end
- Tooltip shows full title

<img width="1254" alt="Screenshot 2024-01-30 at 10 19 35"
src="https://github.com/elastic/kibana/assets/69037875/41cfe6d5-5bd4-41f7-a91f-c2f3bd25943d">
<img width="1259" alt="Screenshot 2024-01-30 at 10 19 49"
src="https://github.com/elastic/kibana/assets/69037875/a9d76bf5-7f94-445e-98bf-e3763d03bdb3">
<img width="1272" alt="Screenshot 2024-01-30 at 10 26 52"
src="https://github.com/elastic/kibana/assets/69037875/642153b1-a8c2-4992-b3fd-187ffe385ca2">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryam-saeidi maryam-saeidi maryam-saeidi approved these changes

Assignees

@benakansara benakansara

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Alert details page][Custom threshold] Adjust main chart title
5 participants
@benakansara @apmmachine @elasticmachine @kibana-ci @maryam-saeidi