Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing angular from Schema and AggParams #17565

Merged
merged 1 commit into from
Apr 9, 2018
Merged

removing angular from Schema and AggParams #17565

merged 1 commit into from
Apr 9, 2018

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Apr 4, 2018 •
edited
Loading

removes angular dependency from:

  • Schema
  • AggParams

(Provider wrapper was removed from all relevant classes. It required only few other code changes which are marked by comment)

@ppisljar ppisljar added WIP Work in progress Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Apr 4, 2018
@ppisljar ppisljar requested a review from timroes April 4, 2018 23:46
@elasticmachine
Copy link
Contributor

💔 Build Failed

@ppisljar ppisljar changed the title WIP: removing angular from Schema, AggParams and AggTypes removing angular from Schema, AggParams and AggTypes Apr 5, 2018
ppisljar
ppisljar commented Apr 5, 2018
View reviewed changes
src/ui/public/agg_types/param_types/field.js
}
fields = propFilter('type')(fields, filters);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

angular filters were replaced in this two lines

@ppisljar ppisljar added review v7.0.0 v6.4.0 and removed WIP Work in progress labels Apr 5, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@ppisljar ppisljar mentioned this pull request Apr 5, 2018
Merged
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@ppisljar ppisljar changed the title removing angular from Schema, AggParams and AggTypes removing angular from Schema and AggParams Apr 5, 2018
@ppisljar ppisljar merged commit d45c8a9 into elastic:master Apr 9, 2018
@ppisljar ppisljar mentioned this pull request Apr 9, 2018
Merged
ppisljar added a commit to ppisljar/kibana that referenced this pull request Apr 9, 2018
@ppisljar
removing angular from Schema, AggParams and AggTypes (elastic#17565)
97f40c1
ppisljar added a commit that referenced this pull request Apr 9, 2018
@ppisljar
removing angular from Schema, AggParams and AggTypes (#17565) (#17610)
cfeb37b
@timroes timroes added v6.3.0 and removed v6.4.0 labels Apr 12, 2018
@aaron-horst aaron-horst mentioned this pull request Jun 20, 2018
Closed
@timroes timroes mentioned this pull request Dec 12, 2018
Closed
58 tasks
@bharatm89 bharatm89 mentioned this pull request Jan 12, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

@thomasneirynck thomasneirynck Awaiting requested review from thomasneirynck

Assignees
No one assigned
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v6.3.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ppisljar @elasticmachine @timroes