[Security Solution] Fix misaligned top nav #175516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angorayc
added
bug
|
buildkite test this |
angorayc
commented
Jan 25, 2024
| @@ -176,7 +176,7 @@ export const isDetectionsPath = (pathname: string): boolean => { | |||
|
|
|||
| export const isDashboardViewPath = (pathname: string): boolean => | |||
| matchPath(pathname, { | |||
| path: `/${DASHBOARDS_PATH}/:id`, | |||
| path: `${DASHBOARDS_PATH}/:detailName`, | |||
There was a problem hiding this comment.
We don't need / here as DASHBOARDS_PATH = /dashboards (x-pack/plugins/security_solution/common/constants.ts line 82)
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @angorayc |
angorayc
changed the title
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 25, 2024
## Summary Issue and steps to reproduce: elastic#171682 Before: <img width="1728" alt="misaligned" src="https://github.com/elastic/kibana/assets/7074629/6c0f8484-7bfb-4329-9029-b53a3c118047"> After: https://github.com/elastic/kibana/assets/6295984/58d3e5bc-0a9a-475b-99dd-00e061b8c4b1 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit a8f538d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 25, 2024
# Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution] Fix misaligned top nav (#175516)](#175516) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Angela Chuang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-25T12:39:12Z","message":"[Security Solution] Fix misaligned top nav (#175516)\n\n## Summary\r\n\r\nIssue and steps to reproduce:\r\nhttps://github.com//issues/171682\r\n\r\nBefore:\r\n\r\n<img width=\"1728\" alt=\"misaligned\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7074629/6c0f8484-7bfb-4329-9029-b53a3c118047\">\r\n\r\n\r\nAfter:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/6295984/58d3e5bc-0a9a-475b-99dd-00e061b8c4b1\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a8f538d15cc40be82bf5abf697a94ee2a5f0466f","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Threat Hunting","Team:Threat Hunting:Explore","Feature:Security Dashboards","v8.12.1","v8.13.0"],"title":"[Security Solution] Fix misaligned top nav","number":175516,"url":"https://github.com/elastic/kibana/pull/175516","mergeCommit":{"message":"[Security Solution] Fix misaligned top nav (#175516)\n\n## Summary\r\n\r\nIssue and steps to reproduce:\r\nhttps://github.com//issues/171682\r\n\r\nBefore:\r\n\r\n<img width=\"1728\" alt=\"misaligned\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7074629/6c0f8484-7bfb-4329-9029-b53a3c118047\">\r\n\r\n\r\nAfter:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/6295984/58d3e5bc-0a9a-475b-99dd-00e061b8c4b1\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a8f538d15cc40be82bf5abf697a94ee2a5f0466f"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/175516","number":175516,"mergeCommit":{"message":"[Security Solution] Fix misaligned top nav (#175516)\n\n## Summary\r\n\r\nIssue and steps to reproduce:\r\nhttps://github.com//issues/171682\r\n\r\nBefore:\r\n\r\n<img width=\"1728\" alt=\"misaligned\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7074629/6c0f8484-7bfb-4329-9029-b53a3c118047\">\r\n\r\n\r\nAfter:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/6295984/58d3e5bc-0a9a-475b-99dd-00e061b8c4b1\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a8f538d15cc40be82bf5abf697a94ee2a5f0466f"}}]}] BACKPORT--> Co-authored-by: Angela Chuang <[email protected]>
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
## Summary Issue and steps to reproduce: elastic#171682 Before: <img width="1728" alt="misaligned" src="https://github.com/elastic/kibana/assets/7074629/6c0f8484-7bfb-4329-9029-b53a3c118047"> After: https://github.com/elastic/kibana/assets/6295984/58d3e5bc-0a9a-475b-99dd-00e061b8c4b1 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue and steps to reproduce: #171682
Before:
After:
Screen.Recording.2024-01-25.at.17.37.34.mov
Checklist
Delete any items that are not applicable to this PR.