[RAM] Implement global alerts page #175143
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
| * in compliance with, at your election, the Elastic License 2.0 or the Server | ||
| * Side Public License, v 1. | ||
| */ | ||
|
|
||
| import { Filter } from '@kbn/es-query'; | ||
| import { EuiContextMenuPanelItemDescriptor } from '@elastic/eui/src/components/context_menu/context_menu'; | ||
|
|
||
| type BaseContextMenuItem = Omit<EuiContextMenuPanelItemDescriptor, 'name' | 'title'>; | ||
|
|
||
| export interface QuickFilter extends BaseContextMenuItem { | ||
| name: string; | ||
| filter: Filter; | ||
| } | ||
|
|
||
| export interface QuickFiltersGroup extends BaseContextMenuItem { | ||
| groupName: string; | ||
| items: QuickFiltersMenuItem[]; | ||
| } | ||
|
|
||
| export type QuickFiltersMenuItem = QuickFiltersGroup | QuickFilter; | ||
|
|
||
| export const isQuickFiltersGroup = ( | ||
| quickFiltersMenuItem: QuickFiltersMenuItem | ||
| ): quickFiltersMenuItem is QuickFiltersGroup => 'items' in quickFiltersMenuItem; |
|
There was a problem hiding this comment. Thanx a lot for the contribution. It seems as a very nice enhancement but it is very specific for the alerts stack page so I would like to make this more generic in unified search. I suggest:
In that way other consumers can use the same logic to display panel items in than menu without the need to integrating this inside unified search Let me know if you have any questions! There was a problem hiding this comment. Thanks for your review @stratoula! 😊 There was a problem hiding this comment. Yes I think that this should come from the consumers of unified search. So after the proposed changes it should look There was a problem hiding this comment. What I mean is that { name: '', filter: {} }render top-level menu items like these: 
whereas items like { groupName: '', items: [...] }render menu items that link to a panel with sub-items (see 
The additionalQueryBarMenuItems={[
{ name: '' }, // Top-level
{ title/groupName: '', items: [{ name: '' }] }, // Nested in subpanel
]}or let the consumer handle the association between panels and items: additionalQueryBarMenuItems={[
{ name: '' }, // Top-level
{ name: '', panel: 1 }, // Link to panel
]}
additionalQueryBarMenuPanels={[
{ id: 1, title: '', items: [...] },
{ id: 2, title: '', items: [...] },
]}
// or alternatively
additionalQueryBarMenuItems={{
items: [...],
panels: [...],
}}There was a problem hiding this comment. Sorry If I was not very clear. I want this additionalQueryBarMenuItemsData to be built outside Unified search. So let's go with this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This map function isn't reused so I don't think it adds readability to define it as a
const. Wrapping it withinquickFilters.maptells me more immediately what this function is being used for.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with you, but in this case the function is recursive so it's actually used more than once:
kibana/src/plugins/unified_search/public/query_string_input/query_bar_menu_panels.tsx
Line 232 in 41c585c
kibana/src/plugins/unified_search/public/query_string_input/query_bar_menu_panels.tsx
Line 254 in 41c585c