[Observability Onboarding Integration] breaks installed integrations page #174804
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
| @@ -201,7 +201,10 @@ export function parseAndVerifyArchive( | |||
| ): ArchivePackage { | |||
| // The top-level directory must match pkgName-pkgVersion, and no other top-level files or directories may be present | |||
| const logger = appContextService.getLogger(); | |||
| const toplevelDir = topLevelDirOverride || paths[0].split('/')[0]; | |||
| let toplevelDir = topLevelDirOverride || ''; | |||
There was a problem hiding this comment.
This fixed my issue. But since I am not aware of the Fleet/Integrations ecosystem, it might not be the correct way to fix the root of the problem.
There was a problem hiding this comment.
the fix looks good to me, if you make the pr ready for review, the CI build will run automatically
There was a problem hiding this comment.
I checked this fix locally and it solved the related error 👍🏻
There was a problem hiding this comment.
I opened it up for review!
mgiota
changed the title
|
buildkite, test this |
|
Could this be a sign that the packages generated by the "custom integration" creation API are not valid anymore? Did anything change about those saved objects that needs to be fixed there? |
|
I suspect #173965 changed how the custom integrations are generated. Maybe something about the assets broke there. |
|
The root cause might be fixed by #174869. |
|
@weltenwort I verify that your fix works fine! So I am closing this draft PR |
|
@weltenwort Sorry I misunderstood, your PR was not meant to replace my PR. So I am reopening this one, since your PR fixes newly created custom integrations and this one fixes existing custom integrations which are already in a broken state. They complement each other and we need both I guess! |
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
mgiota
added
the
Feature:EPM
|
@juliaElastic What should be the proper labels for this PR (version and release notes) |
|
@mgiota Added labels, to backport to 8.12 |
|
@elasticmachine merge upstream |
|
@juliaElastic Cool! I enable auto-merge! |
|
@maryam-saeidi Could you please approve? Nothing really changed since last time you reviewed. |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @mgiota |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
…page (elastic#174804) Fixes elastic#174803 Co-authored-by: Kibana Machine <[email protected]>
|
@juliaElastic I was about it to do the manual backport now, but looks like you already took care of it! Thanks! |
…tions … (#174933) Backport #174804 to 8.12 Co-authored-by: Panagiota Mitsopoulou <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Fixes #174803