Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): replace deprecated cuid with @paralleldrive/cuid2 #174787

Merged
merged 11 commits into from
Feb 12, 2024
Merged

chore(NA): replace deprecated cuid with @paralleldrive/cuid2 #174787

merged 11 commits into from
Feb 12, 2024

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Jan 12, 2024 •
edited by eokoneyo
Loading

Summary

cuid has been deprecated due to security concerns. This PR replaces cuid with the successor @paralleldrive/cuid2 while keeping the usage intact.

Checklist

N/A

Risk Matrix

N/A

For maintainers

@hainenber hainenber requested review from a team as code owners January 12, 2024 18:01
@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Jan 12, 2024 •
edited
Loading

💚 CLA has been signed

@hainenber hainenber changed the title chore(NA): replace deprecated cuid with @paralleldrive/cuid2 chore(NA): replace deprecated cuid with @paralleldrive/cuid2 Jan 15, 2024
@hainenber
Copy link
Contributor Author

Hi, can anyone from Elastic help checking if this is within with expected quality? This small PR helps with Kibana's security, a tiny bit.

@eokoneyo eokoneyo added the release_note:skip Skip the PR/issue when compiling release notes label Jan 22, 2024
@eokoneyo
Copy link
Contributor

@elasticmachine merge upstream

@eokoneyo
Copy link
Contributor

buildkite test this

@eokoneyo eokoneyo self-assigned this Jan 22, 2024
@eokoneyo
Copy link
Contributor

Hey @hainenber thanks for helping to take of this security concern! It seems you installed the replacement package as a dev dependency, but it not used as such. Would you mind switching it to a regular project dependency?

@hainenber
Copy link
Contributor Author

Hey @hainenber thanks for helping to take of this security concern! It seems you installed the replacement package as a dev dependency, but it not used as such. Would you mind switching it to a regular project dependency?

Good catch, thanks! I've moved the replaced package to dependencies section now. PTAL when you have time.

@eokoneyo
Copy link
Contributor

buildkite test this

@eokoneyo
Copy link
Contributor

@elasticmachine merge upstream

@eokoneyo
Copy link
Contributor

buildkite test this

kpollich
kpollich approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes 🚀

vadimkibana
vadimkibana approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@vadimkibana vadimkibana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files service ID generation function LGTM.

@eokoneyo
Copy link
Contributor

eokoneyo commented Feb 9, 2024

buildkite test this

@eokoneyo
Copy link
Contributor

@elasticmachine merge upstream

@eokoneyo
Copy link
Contributor

buildkite test this

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
customIntegrations 38 41 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
customIntegrations 71.2KB 81.0KB +9.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @eokoneyo

@eokoneyo eokoneyo merged commit 8fb4bf2 into elastic:main Feb 12, 2024
33 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Feb 12, 2024
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@hainenber @kibanamachine @CoenWarmer
chore(NA): replace deprecated cuid with @paralleldrive/cuid2 (ela…
0b86615 
…stic#174787)

## Summary

`cuid` has been deprecated due to security concerns. This PR replaces
`cuid` with the successor `@paralleldrive/cuid2` while keeping the usage
intact.

### Checklist
N/A

### Risk Matrix
N/A



### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@hainenber @kibanamachine @fkanout
chore(NA): replace deprecated cuid with @paralleldrive/cuid2 (ela…
56d7735 
…stic#174787)

## Summary

`cuid` has been deprecated due to security concerns. This PR replaces
`cuid` with the successor `@paralleldrive/cuid2` while keeping the usage
intact.

### Checklist
N/A

### Risk Matrix
N/A



### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadimkibana vadimkibana vadimkibana approved these changes

@kpollich kpollich kpollich approved these changes

Assignees

@eokoneyo eokoneyo

Labels
backport:skip This commit does not require backporting 💝community release_note:skip Skip the PR/issue when compiling release notes v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hainenber @eokoneyo @kibana-ci @kpollich @vadimkibana @kibanamachine