Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Add support for =~ operator #174732

Merged
merged 17 commits into from
Jan 30, 2024

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Jan 12, 2024

Summary

Keep in sync with new ES|QL builtin function addition: elastic/elasticsearch#103656

Do not merge until the related ER PR is still in review.

Checklist

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:ES|QL ES|QL related features in Kibana v8.13.0 labels Jan 12, 2024
@dej611
Copy link
Contributor Author

dej611 commented Jan 12, 2024

/ci

@dej611
Copy link
Contributor Author

dej611 commented Jan 22, 2024

/ci

@dej611
Copy link
Contributor Author

dej611 commented Jan 29, 2024

/ci

@dej611
Copy link
Contributor Author

dej611 commented Jan 29, 2024

Reviewable as the ES counterpart has been merged.

@dej611 dej611 marked this pull request as ready for review January 29, 2024 09:59
@dej611 dej611 requested a review from a team as a code owner January 29, 2024 09:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@dej611
Copy link
Contributor Author

dej611 commented Jan 30, 2024

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 2.9MB 2.9MB +182.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Did a very brief testing locally and it works fine!

@dej611 dej611 merged commit 5c86438 into elastic:main Jan 30, 2024
18 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 30, 2024
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
## Summary

Keep in sync with new ES|QL builtin function addition:
elastic/elasticsearch#103656

Do not merge until the related ER PR is still in review.

### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
## Summary

Keep in sync with new ES|QL builtin function addition:
elastic/elasticsearch#103656

Do not merge until the related ER PR is still in review.

### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants