Don't count lone wildcards as leading wildcards #17462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bargs
commented
Mar 29, 2018
| const regex = value | ||
| .split(wildcardSymbol) | ||
| .map(escapeRegExp) | ||
| .join('.*'); |
There was a problem hiding this comment.
Just reformatting via Prettier
Bargs
commented
Mar 29, 2018
| return value | ||
| .split(wildcardSymbol) | ||
| .map(escapeQueryString) | ||
| .join('*'); |
There was a problem hiding this comment.
Just reformatting via Prettier
lukasolson
approved these changes
Mar 29, 2018
|
Test added |
💔 Build Failed |
w33ble
approved these changes
Mar 29, 2018
|
jenkins, test this |
💚 Build Succeeded |
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Mar 30, 2018
The addition of the optional flag to disable leading wildcards inadvertently broke exists queries, which are accomplished in kuery with the fieldName:* syntax.
Bargs
added a commit
that referenced
this pull request
Mar 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of the optional flag to disable leading wildcards inadvertently broke exists queries, which are accomplished in kuery with the
fieldName:*syntax. Example of the error:This PR just loosens the check in the hasLeadingWildcard helper.