Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Detection Engine] fixes broken tests in serverless for IM and saved query rules #174580

Merged
merged 8 commits into from
Jan 15, 2024
Merged

[Security Solution][Detection Engine] fixes broken tests in serverless for IM and saved query rules #174580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c1afa16
unskip tests
vitaliidm Jan 10, 2024
c0f4b8a
Merge branch 'main' into detection-engine/investigate-broken-in-serve…
vitaliidm Jan 10, 2024
e64151c
remove lifecycle policy
vitaliidm Jan 10, 2024
8f2991b
Merge branch 'main' into detection-engine/investigate-broken-in-serve…
vitaliidm Jan 10, 2024
0173305
Update custom_saved_query_rule.cy.ts
vitaliidm Jan 11, 2024
ce88257
Update indicator_match_rule.cy.ts
vitaliidm Jan 11, 2024
5d263ac
Merge branch 'main' into detection-engine/investigate-broken-in-serve…
vitaliidm Jan 11, 2024
8acbeb7
Merge branch 'main' into detection-engine/investigate-broken-in-serve…
vitaliidm Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...press/e2e/detection_response/detection_engine/rule_creation/custom_saved_query_rule.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@ const savedQueryName = 'custom saved query';
const savedQueryQuery = 'process.name: test';
const savedQueryFilterKey = 'testAgent.value';

// TODO: https://github.com/elastic/kibana/issues/161539
describe('Saved query rules', { tags: ['@ess', '@serverless', '@brokenInServerless'] }, () => {
describe('Saved query rules', { tags: ['@ess', '@serverless'] }, () => {
describe('Custom saved_query detection rule creation', () => {
beforeEach(() => {
login();
Expand Down
3 changes: 1 addition & 2 deletions .../cypress/e2e/detection_response/detection_engine/rule_creation/indicator_match_rule.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,7 @@ import { deleteAlertsAndRules } from '../../../../tasks/api_calls/common';

const DEFAULT_THREAT_MATCH_QUERY = '@timestamp >= "now-30d/d"';

// TODO: https://github.com/elastic/kibana/issues/161539
describe('indicator match', { tags: ['@ess', '@serverless', '@brokenInServerless'] }, () => {
describe('indicator match', { tags: ['@ess', '@serverless'] }, () => {
describe('Detection rules, Indicator Match', () => {
const expectedUrls = getNewThreatIndicatorRule().references?.join('');
const expectedFalsePositives = getNewThreatIndicatorRule().false_positives?.join('');
Expand Down
4 changes: 0 additions & 4 deletions x-pack/test/security_solution_cypress/es_archives/threat_indicator/mappings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,10 +811,6 @@
},
"settings": {
"index": {
"lifecycle": {
"name": "filebeat",
"rollover_alias": "filebeat-7.12.0"
},
"mapping": {
"total_fields": {
"limit": "10000"
Expand Down