Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless Search] Fix failing MKI tests for connectors UI #174488

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ export function SvlSearchConnectorsPageProvider({ getService }: FtrProviderConte
await testSubjects.existOrFail('serverlessSearchCancelNameButton');
await testSubjects.setValue('serverlessSearchEditNameFieldText', name);
await testSubjects.click('serverlessSearchSaveNameButton');
await retry.waitForWithTimeout('edit name form to disappear', 2000, () =>
saarikabhasi marked this conversation as resolved.
Show resolved Hide resolved
testSubjects
.missingOrFail('serverlessSearchSaveNameButton')
.then(() => true)
.catch(() => false)
);
await testSubjects.exists('serverlessSearchConnectorName');
expect(await testSubjects.getVisibleText('serverlessSearchConnectorName')).to.be(name);
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const browser = getService('browser');
describe('connectors', function () {
// failsOnMKI, see https://github.com/elastic/kibana/issues/173929
this.tags(['failsOnMKI']);
before(async () => {
await pageObjects.svlCommonPage.login();
await pageObjects.svlCommonNavigation.sidenav.clickLink({
Expand Down Expand Up @@ -65,7 +63,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
pageObjects.svlSearchConnectorsPage.connectorOverviewPage.expectSearchBarToExist();
});

it('searchBar and select filter connector table', async () => {
it('searchBar and select, filters connector table', async () => {
pageObjects.svlSearchConnectorsPage.connectorOverviewPage.getConnectorFromConnectorTable(
TEST_CONNECTOR_NAME
);
Expand Down