Fix issue with KQL wildcard queries not properly escaping backslashes #174464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
added
release_note:fix
Feature:KQL
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
mattkime
approved these changes
Jan 9, 2024
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @lukasolson |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 9, 2024
…elastic#174464) ## Summary Fixes elastic#169709. Prior to this PR, KQL queries against keyword fields would not properly handle escaped special characters (such as backslash). This PR fixes the behavior to properly re-escape special characters before sending them along to the wildcard query. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### Release note KQL queries against wildcards now properly handle escaped special characters without requiring double-escaping. Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 46fbfd3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 9, 2024
…slashes (#174464) (#174533) # Backport This will backport the following commits from `main` to `8.12`: - [Fix issue with KQL wildcard queries not properly escaping backslashes (#174464)](#174464) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lukas Olson","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-09T16:24:12Z","message":"Fix issue with KQL wildcard queries not properly escaping backslashes (#174464)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/169709.\r\n\r\nPrior to this PR, KQL queries against keyword fields would not properly\r\nhandle escaped special characters (such as backslash). This PR fixes the\r\nbehavior to properly re-escape special characters before sending them\r\nalong to the wildcard query.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### Release note\r\n\r\nKQL queries against wildcards now properly handle escaped special\r\ncharacters without requiring double-escaping.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"46fbfd3b13c80d49e51b6b1541fecebb7c628e02","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:KQL","Team:DataDiscovery","v8.12.1","v8.13.0"],"title":"Fix issue with KQL wildcard queries not properly escaping backslashes","number":174464,"url":"https://github.com/elastic/kibana/pull/174464","mergeCommit":{"message":"Fix issue with KQL wildcard queries not properly escaping backslashes (#174464)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/169709.\r\n\r\nPrior to this PR, KQL queries against keyword fields would not properly\r\nhandle escaped special characters (such as backslash). This PR fixes the\r\nbehavior to properly re-escape special characters before sending them\r\nalong to the wildcard query.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### Release note\r\n\r\nKQL queries against wildcards now properly handle escaped special\r\ncharacters without requiring double-escaping.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"46fbfd3b13c80d49e51b6b1541fecebb7c628e02"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174464","number":174464,"mergeCommit":{"message":"Fix issue with KQL wildcard queries not properly escaping backslashes (#174464)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/169709.\r\n\r\nPrior to this PR, KQL queries against keyword fields would not properly\r\nhandle escaped special characters (such as backslash). This PR fixes the\r\nbehavior to properly re-escape special characters before sending them\r\nalong to the wildcard query.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### Release note\r\n\r\nKQL queries against wildcards now properly handle escaped special\r\ncharacters without requiring double-escaping.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"46fbfd3b13c80d49e51b6b1541fecebb7c628e02"}}]}] BACKPORT--> Co-authored-by: Lukas Olson <[email protected]>
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Jan 10, 2024
…elastic#174464) ## Summary Fixes elastic#169709. Prior to this PR, KQL queries against keyword fields would not properly handle escaped special characters (such as backslash). This PR fixes the behavior to properly re-escape special characters before sending them along to the wildcard query. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### Release note KQL queries against wildcards now properly handle escaped special characters without requiring double-escaping. Co-authored-by: Kibana Machine <[email protected]>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Jan 11, 2024
…elastic#174464) ## Summary Fixes elastic#169709. Prior to this PR, KQL queries against keyword fields would not properly handle escaped special characters (such as backslash). This PR fixes the behavior to properly re-escape special characters before sending them along to the wildcard query. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### Release note KQL queries against wildcards now properly handle escaped special characters without requiring double-escaping. Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #169709.
Prior to this PR, KQL queries against keyword fields would not properly handle escaped special characters (such as backslash). This PR fixes the behavior to properly re-escape special characters before sending them along to the wildcard query.
Checklist
Release note
KQL queries against wildcards now properly handle escaped special characters without requiring double-escaping.