[Reporting ] run task function simplifications of image export types #174410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
force-pushed
the
reporting-image-export-cleanups
branch
from
ae688e9 to
bb06f98
Compare
tsullivan
added
release_note:skip
tsullivan
changed the title
|
buildkite build this |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
rshen91
approved these changes
Jan 10, 2024
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Jan 11, 2024
…lastic#174410) ## Summary This PR cleans up extra layers of abstraction in image export types that could complicate progress of the proposal of "auto" timeouts. See elastic#131852 ## Changes Minor code cleanup of the "runTask" functions of export types that create screenshots, by removing the `generatePdf*` / `generatePng` helper callback functions and inlining the work those modules were doing. The helper modules were an integral part of the screenshotting pipelines, but in the unit tests they were completely mocked. Now that we have a proper mock utility of the `screenshotting` plugin start contract, we no longer need mockable code in a separate layer of the pipelines. --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans up extra layers of abstraction in image export types that could complicate progress of the proposal of "auto" timeouts. See #131852
Changes
Minor code cleanup of the "runTask" functions of export types that create screenshots, by removing the
generatePdf*/generatePnghelper callback functions and inlining the work those modules were doing.The helper modules were an integral part of the screenshotting pipelines, but in the unit tests they were completely mocked. Now that we have a proper mock utility of the
screenshottingplugin start contract, we no longer need mockable code in a separate layer of the pipelines.