-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aria-label attributes to indexed fields table, and use EuiIconTip #17427
Add aria-label attributes to indexed fields table, and use EuiIconTip #17427
Conversation
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the two suggestions this looks good to me.
<EuiIconTip | ||
type="clock" | ||
color="primary" | ||
aria-label="Info" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather suggest using a short version of the description here as a label, like "Primary time field".
That way a screenreader would read out:
🗣️ Primary time field -pause- This field represents the time that events occurred.
vs:
🗣️ Info -pause- This field represents the time that events occurred.
That way a screen reader user once familiar to what the time field means, can immediately jump to the next element, once she heard "primary time field", instead of needing to wait for the long explanation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense! updating
<EuiIconTip | ||
type="alert" | ||
color="warning" | ||
aria-label="Warning" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, I would suggest using something like "Multiple type field" instead of "Warning".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense! updating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tim's comments totally make sense and not something I would have caught! I'd definitely second them!
💚 Build Succeeded |
…elastic#17427) * Add aria-label attributes to indexed fields table, and use EuiIconTip * Use EUI 0.0.35 * Add `Apache License, Version 2.0` to list
Fixes #17410
Fixes #17411
Improve accessibility of indexed fields table by adding
aria-label
to the boolean indicators (green dots), and replace<EuiToolTip><EuiIcon/></EuiToolTip>
with<EuiIconTip/>
.Bump EUI to 0.0.35 to support color prop for EuiIconTip.