Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless Search] Add consistent toast messages for all APIs #173989

Merged

Conversation

sphilipse
Copy link
Member

Summary

This adds default error toast messages to all API calls in the Serverless Elasticsearch plugin, and provides some ways to skip or modify the toasts.

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.13.0 labels Dec 27, 2023
@sphilipse sphilipse requested a review from a team December 27, 2023 13:17
@sphilipse
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Member

@efegurkan efegurkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@sphilipse sphilipse enabled auto-merge (squash) January 2, 2024 13:50
auto-merge was automatically disabled January 2, 2024 13:55

Base branch was modified

@sphilipse
Copy link
Member Author

@elasticmachine merge upstream

@sphilipse
Copy link
Member Author

@elasticmachine merge upstream

@sphilipse sphilipse enabled auto-merge (squash) January 4, 2024 05:14
@sphilipse
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #23 / cases security and spaces enabled: trial push_case memoryless server user profile uid falls back to authc to get the user information when the profile uid is not available

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
serverlessSearch 336 335 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
serverlessSearch 425.5KB 424.3KB -1.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
serverlessSearch 55.6KB 56.2KB +568.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sphilipse sphilipse merged commit 07948b9 into elastic:main Jan 4, 2024
22 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants