[chore] Correct dependency inconsistencies in Presentation team plugins

[clintandrewhall]

Changes identified using the script from #171483

Summary

The script from #171483 can identify inconsistencies and untyped dependencies in Kibana plugins. This PR fixes all of the plugins owned by @elastic/kibana-presentation.

Caveats

• These changes have had only rudimentary testing in the application. There may be side-effects, where a dependency is not explicitly used, but adds some necessary, implicit effect. These dependencies should at the very least be avoided, if not outright eliminated.

Follow-up

• expression_* plugins should be consolidated and moved to a package.

controls

• Dependencies for the server layer were not explicitly defined on the plugin class.
• kibanaReact and presentationUtil were used statically, and there should be required bundles.
• savedObjects and expressions were not used at all-- check for side-effects!

dashboard

• controls, kibanaReact, kibanaUtils, presentationUtil, controls, and savedObjectsFinder are all used statically; they should be required bundles instead.
• share is used optionally as a dependency and statically to import components. It was likely made required to avoid the build error, (optional plugins cannot be used statically). share was moved to both collections.
• taskManager and usageCollection are optional plugins, but required in the TS types. The types were refactored to reflect the manifest.
• dataViews was not used at all.
• customBranding was listed in the Typescript type, but missing from the manifest, and unused. This was likely a leftover from the move to core, type removed

embeddable

• Dependencies for both the public and server layer were not explicitly defined on the plugin class.
• data and savedObjectsFinder are both used statically; they should be required bundles instead.
• usageCollection was listed in the manifest as optional; updated type.

expression_*

• The start dependencies relied on expression rather than expressionS. They were also entirely unused.
• presentationUtil is used statically; it should be a required bundle instead.

inputControlVis

• Dependencies for the public layer were not explicitly defined on the plugin class.
• None of the public start dependencies are used.
• visDefaultEditor is used statically; it should be a required bundle instead.

inspector

• Dependencies for the public layer were not explicitly defined on the plugin class.

links

• Dependencies for the public layer were not explicitly nor correctly defined on the plugin class.
• uiActionsEnhanced and savedObjects are both used statically; they should be required bundles instead.
• kibanaReact and kibanaUtils were unused.
• usageCollection should be optional in the manifest.

presentationUtil

• Dependencies for both the public and server layer were neither explicitly nor correctly defined on the plugin class.
• savedObjects, kibanaReact, expressions and embeddable are all used statically; they should be required bundles instead.

canvas

• Dependencies for the server layer were not explicitly nor correctly defined on the plugin class.
• fieldFormats, savedObjectFinder and expression* are all used statically; they should be required bundles instead.
• usageCollection should be optional in the manifest.
• home should be optional in the Typescript type and in logic.

dashboardEnhanced

• unifiedSearch is unused. check for side effects!
• uiActionsEnhanced is used statically; it should be a required bundle instead.

embeddableEnhanced

• kibanaReact and uiActions are unused.

[ThomThomson]

Changes LGTM! Ran some smoke tests locally and looked through the code changes. Great cleanup!

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 5c00157

Failed CI Steps

• FTR Configs #11

Metrics [docs]

✅ unchanged

History

• 💔 Build #186653 failed 1dd70f12b633fcef35cb5b5a0b6ba0e49465de51
• 💔 Build #186649 failed 5d23382
• 💔 Build #186000 failed 0392680
• 💚 Build #185102 succeeded 752f5e6
• 💚 Build #184862 succeeded a607185

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream