Add ResizeObserver polyfill globally in Jest tests #173772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
added
release_note:skip
markov00
force-pushed
the
2023_12_20-remove_resize_observer_mocks
branch
from
5b45013 to
9b34fc3
Compare
5 tasks
botelastic
bot
added
the
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Ikuni17
approved these changes
Jan 9, 2024
smith
approved these changes
Jan 9, 2024
maxcold
approved these changes
Jan 10, 2024
pheyos
approved these changes
Jan 10, 2024
|
@elasticmachine merge upstream |
kqualters-elastic
approved these changes
Jan 17, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.13.0
backport:skip
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
## Summary This PR adds the ResizeObserver polyfill in Jest Tests reusing a polyfill already used in Kibana. The PR also removes all the mocks for the ResizeObserver used in tests. The polyfill is no longer needed in code running on a browser as the [ResizeObserver API is already available](https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver#browser_compatibility) in every Kibana-supported browser. There is still one last polyfill to remove `@juggle/resize-observer` but this is used internally by the `use-resize-observer` hook. A following PR could probably replace that hook with a different hook that doesn't require that polyfill to cleanup a bit our dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ResizeObserver polyfill in Jest Tests reusing a polyfill already used in Kibana.
The PR also removes all the mocks for the ResizeObserver used in tests.
The polyfill is no longer needed in code running on a browser as the ResizeObserver API is already available in every Kibana supported browser.
There is still one last polyfill to remove
@juggle/resize-observerbut this is used internally by theuse-resize-observerhook. A following PR could probably replace that hook with a different hook that doesn't require that polyfill to cleanup a bit our dependencies