[Security Solution] Re-enable the timelines url state test #173536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgestc
changed the title
25 tasks
lgestc
force-pushed
the
iss_172503_url_state_flaky_test
branch
from
dd3cb9c to
c898971
Compare
|
/ci |
lgestc
added
Team:Threat Hunting:Investigations
PhilippeOberti
requested changes
Dec 20, 2023
There was a problem hiding this comment.
We should get rid of the before and use beforeEach only. If a test fails then all the code in the before will not be run again when the test is retried.
Also why login twice (currently we call login in the before then again in the beforeEach).
Once you move the content of the before into the beforeEach, I wonder if we should clear all created timeline to make sure that the tests start fresh always? (here is the function that does it for you).
Also I feel like the nested describe (line 45) isn't doing anything, so let's remove it!
lgestc
force-pushed
the
iss_172503_url_state_flaky_test
branch
2 times, most recently
from
f6eb950 to
43b7986
Compare
PhilippeOberti
approved these changes
Dec 20, 2023
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enables #172503
FTR pipeline: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4615