[Security Solution] Fix flaky timeline pagination tests #173531
Conversation
|
/ci |
lgestc
changed the title
|
/ci |
1 similar comment
|
/ci |
lgestc
force-pushed
the
iss_169413_flaky_timeline_pagination
branch
from
12b927f to
6cb1c40
Compare
|
/ci |
lgestc
added
Team:Threat Hunting:Investigations
There was a problem hiding this comment.
I approved the PR, but I feel like we should extract the click event into separate methods to follow the convention. I'll let you decide if you want to do it or not! 😄
Also I feel like the string in the top level describe (Pagination) and the title of the actual test (should paginate records correctly) isn't super descriptive of what the test is actually testing. Is it in timeline? (I'm guessing yes because it's in the timeline folder). Is it a specific tab? I feel like to make this easier to understand one or both should be changed/impdoved... Thoughts?
|
|
||
| it('should be able to go to next / previous page', () => { | ||
| // should be able to go to next / previous page |
There was a problem hiding this comment.
should we extract the next 2 lines in a tasks functions?
| const itemsPerPage = 100; | ||
| cy.get(TIMELINE_EVENTS_COUNT_PER_PAGE_BTN).first().click({ force: true }); | ||
| cy.get(TIMELINE_EVENTS_COUNT_PER_PAGE_BTN).first().click(); |
There was a problem hiding this comment.
should we extract the next 2 lines in a tasks functions?
lgestc
force-pushed
the
iss_169413_flaky_timeline_pagination
branch
from
d294a32 to
c94ed80
Compare
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
Fixes #169413 #169619
and colocates related tests cases.
Flaky TR pipeline: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4614