Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLO] Improve equivalent API View #173503

Merged
merged 7 commits into from
Dec 20, 2023
Merged

[SLO] Improve equivalent API View #173503

merged 7 commits into from
Dec 20, 2023

Conversation

shahzad31
Copy link
Contributor

Summary

Instead of copy JSON button, show JSON in flyout with option to copy as well

image

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31
Copy link
Contributor Author

/ci

@shahzad31
Copy link
Contributor Author

/ci

@shahzad31 shahzad31 marked this pull request as ready for review December 19, 2023 15:56
@shahzad31 shahzad31 requested a review from a team as a code owner December 19, 2023 15:56
@shahzad31 shahzad31 added the release_note:skip Skip the PR/issue when compiling release notes label Dec 19, 2023
@simianhacker simianhacker self-requested a review December 19, 2023 18:51
simianhacker
simianhacker approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is a step forward. Eventually we might want to put different languages.

@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Dec 19, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #41 / security APIs - Audit Log Audit Log logs audit events when reading and writing saved objects

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.2MB 1.2MB +1.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit fbf9fe4 into elastic:main Dec 20, 2023
36 checks passed
@shahzad31 shahzad31 deleted the json-view-api branch December 20, 2023 08:50
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simianhacker simianhacker simianhacker approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shahzad31 @apmmachine @elasticmachine @kibana-ci @simianhacker @kibanamachine