[Index Management] Fix managed data streams badge #173408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuliacech
added
release_note:fix
Feature:Index Management
|
/ci |
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
ElenaStoeva
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Thanks for fixing this @yuliacech! Tested locally and code changes LGTM.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.13.0
backport:skip
wayneseymour
added a commit
to wayneseymour/kibana
that referenced
this pull request
Apr 19, 2024
…mmon/management/index_management/data_streams.ts ## Failing on Serverless File last modified in: elastic#173408 ## Error message Error: expected 'Error updating data retention: \'Request for uri [/_data_stream/test-ds-1/_lifecycle] with method [DELETE] exists but is not available when running in serverless mode\'' to contain 'Data retention disabled' at Assertion.assert (expect.js:100:11) at Assertion.contain (expect.js:442:10) at Context. (data_streams.ts:137:54) at processTicksAndRejections (node:internal/process/task_queues:95:5) at Object.apply (wrap_function.js:73:16)
mistic
pushed a commit
that referenced
this pull request
Apr 20, 2024
#181243) …mmon/management/index_management/data_streams.ts See issue for details: #181242 ## Failing on Serverless File last modified in: #173408 ## Error message Error: expected 'Error updating data retention: \'Request for uri [/_data_stream/test-ds-1/_lifecycle] with method [DELETE] exists but is not available when running in serverless mode\'' to contain 'Data retention disabled' at Assertion.assert (expect.js:100:11) at Assertion.contain (expect.js:442:10) at Context. (data_streams.ts:137:54) at processTicksAndRejections (node:internal/process/task_queues:95:5) at Object.apply (wrap_function.js:73:16)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the badge "managed" missing from the data streams list. The code used to check that the data stream has both conditions for a managed data streams
meta.managed: trueandmeta.managed_by: 'ingest-manager'. The check foringest-manageris not coorect since it's been renamed to fleet. Instead of updating the check though, I decided to only leave the condition formeta.managed : trueand I removed all mentions of "Fleet" from the Data streams tab. I believe that is more consistent for the UI, since we don't mention "Fleet-managed" anywhere else like ILM, index templates etc.Screenshot
Release Note
Fixed the badge for managed data streams in Index Management