Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Detections Response][FTR] FTR migration cleanup #173403

Merged
merged 13 commits into from
Jan 12, 2024
Merged

[Detections Response][FTR] FTR migration cleanup #173403

merged 13 commits into from
Jan 12, 2024

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Dec 14, 2023 •
edited by kibanamachine
Loading

Summary

Addressing feedback from #172173.

This is not yet addressing file restructure, going to keep the file restructure in a separate PR to try to make reviews more readable.

@yctercero yctercero self-assigned this Dec 14, 2023
@yctercero yctercero added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team:Detection Engine Security Solution Detection Engine Area v8.12.0 v8.13.0 labels Dec 14, 2023
@yctercero yctercero changed the title updating per PR feedback [Detections Response][FTR] FTR migration cleanup Dec 14, 2023
@yctercero yctercero marked this pull request as ready for review December 14, 2023 17:29
@yctercero yctercero requested review from a team as code owners December 14, 2023 17:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@yctercero yctercero mentioned this pull request Dec 14, 2023
Closed
jpdjere
jpdjere approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@jpdjere jpdjere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule Management LGTM 👍

@yctercero
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@yctercero yctercero enabled auto-merge (squash) January 12, 2024 18:41
JDKurma
JDKurma approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@JDKurma JDKurma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDA LGTM!

@yctercero yctercero merged commit a202d3f into elastic:main Jan 12, 2024
19 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.12 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.12:
- [Security Solution] Add retryIfConflict util for 409 conflicts in Integration tests (#174185)

Manual backport

To create the backport manually run:

node scripts/backport --pr 173403

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Feb 19, 2024
Merged
2 tasks
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 173403 locally

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 12, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 173403 locally

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 173403 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 173403 locally

@jbudz jbudz added the backport:skip This commit does not require backporting label Sep 30, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JDKurma JDKurma JDKurma approved these changes

@nkhristinin nkhristinin nkhristinin approved these changes

@jpdjere jpdjere jpdjere approved these changes

Assignees

@yctercero yctercero

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team v8.12.0 v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@yctercero @elasticmachine @kibana-ci @kibanamachine @jpdjere @nkhristinin @JDKurma @jbudz