Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fix flaky sourcerer timeline test #173288

Merged
merged 4 commits into from
Dec 19, 2023
Merged

[Security Solution] Fix flaky sourcerer timeline test #173288

merged 4 commits into from
Dec 19, 2023

Conversation

lgestc
Copy link
Contributor

@lgestc lgestc commented Dec 13, 2023 •
edited
Loading

Summary

This hopefully #fixes #169402

What was fixed:
It seems that the options selected in the sourcerer dropdown were no longer valid. I am now altering the default value which will always be there.

Flaky test runner build:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4573#018c68c9-08c0-4c87-8554-97a1fe1650db

@lgestc lgestc added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Threat Hunting:Investigations Security Solution Investigations Team 8.13 candidate labels Dec 13, 2023
@lgestc lgestc requested a review from a team as a code owner December 13, 2023 14:29
@lgestc lgestc requested a review from yctercero December 13, 2023 14:29
@lgestc
Copy link
Contributor Author

lgestc commented Dec 13, 2023

@elasticmachine merge upstream

@lgestc lgestc marked this pull request as draft December 13, 2023 16:28
@lgestc lgestc force-pushed the fix_flaky_test_169402 branch 2 times, most recently from c6d5a09 to 55a8f89 Compare December 14, 2023 14:42
@lgestc lgestc force-pushed the fix_flaky_test_169402 branch from 55a8f89 to 13fbb9f Compare December 14, 2023 15:36
@lgestc lgestc marked this pull request as ready for review December 14, 2023 16:03
@lgestc
Copy link
Contributor Author

lgestc commented Dec 14, 2023

/ci

@lgestc lgestc mentioned this pull request Dec 15, 2023
Closed
25 tasks
yctercero
yctercero approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing the flake!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lgestc lgestc merged commit 1004ddb into elastic:main Dec 19, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yctercero yctercero yctercero approved these changes

Assignees
No one assigned
Labels
8.13 candidate backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.13.0
Projects
None yet
Milestone
No milestone
4 participants
@lgestc @kibana-ci @yctercero @kibanamachine