[Lens] fixed equality check for visualization #172685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
Team:Visualizations
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
dej611
reviewed
Dec 6, 2023
| const customIsEqual = visualizationMap[previousAttrs.visualizationType]?.isEqual; | ||
| const visualizationStateIsEqual = customIsEqual | ||
| ? (() => { | ||
| try { |
There was a problem hiding this comment.
Why wrapping it in a try here?
There was a problem hiding this comment.
for xy_chart, the implementation of isEqual can throw an error when injecting references for annotations. If there's a problem with annotation from library, it can throw an error.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
stratoula
approved these changes
Dec 7, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 7, 2023
## Summary Fixed an equality check bug for attributesChanged calculation. It wasn't taking into account that visualization can also have references (to dataview for annotations) and a custom isEqual function. (cherry picked from commit 9e41850)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 7, 2023
# Backport This will backport the following commits from `main` to `8.12`: - [[Lens] fixed equality check for visualization (#172685)](#172685) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marta Bondyra","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-07T09:31:38Z","message":"[Lens] fixed equality check for visualization (#172685)\n\n## Summary\r\n\r\nFixed an equality check bug for attributesChanged calculation. It wasn't\r\ntaking into account that visualization can also have references (to\r\ndataview for annotations) and a custom isEqual function.","sha":"9e41850a352a24446a0c49bacffccf93df2547fb","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","v8.12.0","v8.13.0"],"number":172685,"url":"https://github.com/elastic/kibana/pull/172685","mergeCommit":{"message":"[Lens] fixed equality check for visualization (#172685)\n\n## Summary\r\n\r\nFixed an equality check bug for attributesChanged calculation. It wasn't\r\ntaking into account that visualization can also have references (to\r\ndataview for annotations) and a custom isEqual function.","sha":"9e41850a352a24446a0c49bacffccf93df2547fb"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172685","number":172685,"mergeCommit":{"message":"[Lens] fixed equality check for visualization (#172685)\n\n## Summary\r\n\r\nFixed an equality check bug for attributesChanged calculation. It wasn't\r\ntaking into account that visualization can also have references (to\r\ndataview for annotations) and a custom isEqual function.","sha":"9e41850a352a24446a0c49bacffccf93df2547fb"}}]}] BACKPORT--> Co-authored-by: Marta Bondyra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed an equality check bug for attributesChanged calculation. It wasn't taking into account that visualization can also have references (to dataview for annotations) and a custom isEqual function.