Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Connectors][PagerDuty] Edit labels for optional fields and generate docs #172123

Merged
merged 9 commits into from
Nov 30, 2023
Merged

[Connectors][PagerDuty] Edit labels for optional fields and generate docs #172123

merged 9 commits into from
Nov 30, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 29, 2023

Summary

Relates to #170048

This PR:

  • Updates the PagerDuty connector UI so that the "optional" qualifier is subdued and separated from the field labels.
  • Refreshes the automated screenshots so that the documentation reflects the UI changes.
  • Updates the PagerDuty connector documentation to describe the new "Links" and "Custom details" fields associated with trigger actions.
  • Sorts the field descriptions in the PagerDuty connector documentation so they're listed alphabetically.

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework v8.12.0 labels Nov 29, 2023
@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl marked this pull request as ready for review November 29, 2023 15:29
@lcawl lcawl requested a review from a team as a code owner November 29, 2023 15:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@lcawl lcawl requested a review from cnasikas November 29, 2023 15:29
cnasikas
cnasikas approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

x-pack/plugins/stack_connectors/public/connector_types/pagerduty/pagerduty_params.tsx Outdated Show resolved Hide resolved
@lcawl lcawl enabled auto-merge (squash) November 29, 2023 20:06
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackConnectors 540.0KB 542.2KB +2.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit 462bb3a into elastic:main Nov 30, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcawl @apmmachine @elasticmachine @kibana-ci @cnasikas