Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ELSER text expansion callout's code #171678

Merged
merged 7 commits into from
Nov 22, 2023
Merged

Move ELSER text expansion callout's code #171678

merged 7 commits into from
Nov 22, 2023

Conversation

Mikep86
Copy link
Contributor

@Mikep86 Mikep86 commented Nov 21, 2023

Summary

Move ELSER text expansion callout's code into a subfolder

@Mikep86 Mikep86 added release_note:skip Skip the PR/issue when compiling release notes v8.12.0 labels Nov 21, 2023
@Mikep86 Mikep86 requested review from demjened, kderusso and a team November 21, 2023 18:27
demjened
demjened reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@demjened demjened left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mikep86 Added a non-blocking comment.

...erprise_search_content/components/search_index/pipelines/ml_inference/configure_pipeline.tsx Outdated Show resolved Hide resolved
kderusso
kderusso reviewed Nov 21, 2023
View reviewed changes
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending Adam's rename suggestion. I can approve for merge if you'd like after CI is green.

demjened
demjened approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@demjened demjened left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 22, 2023 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Mikep86
Copy link
Contributor Author

Mikep86 commented Nov 22, 2023

@elasticmachine run elasticsearch-ci/docs

@Mikep86 Mikep86 merged commit a9c41e5 into elastic:main Nov 22, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kderusso kderusso kderusso left review comments

@demjened demjened demjened approved these changes

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Mikep86 @kibana-ci @TattdCodeMonkey @demjened @kderusso @kibanamachine