-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security solution] Fix streaming on cloud #171578
Conversation
@elasticmachine merge upstream |
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Unfortunately, the strategy to use a TransformStream in the
invokeStream
method (see 1, 2) was unsuccessful in production. The transform caused additional latency and caused the stream not to work at all when passing through the cloud proxy. I removed the TransformStream from the stack_connectors, and instead we need to count on the consumer to properly parse the response stream.Bedrock
Bedrock will sometimes send multiple messages in one buffer. To account for this, I again followed the langchain bedrock extension and used a concatenated buffer to process multiple messages one at a time.
To test
vault
to access creds:vault read secret/kibana-issues/dev/cloud-deploy/kibana-pr-171578