Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Defend Workflows] Enable Artifacts cy tests against serverless #170977

Conversation

gergoabraham
Copy link
Contributor

@gergoabraham gergoabraham commented Nov 9, 2023

Summary

Enables Artifact tabs in Policy details and Artifacts cypress tests against serverless. Or at least the test cases that has ALL privilege (or NONE for the Artifacts tests), because there are no such roles in serverless environment that have:

  • read privilege for policy, but no privilege for artifacts,
  • read privilege for artifacts

Additionally,

  • @skipInServerless tag is added,
  • the two tests use the usual indexEndpointHosts() to have mocked data,
  • and the old loadEndpointDataForEventFiltersIfNeeded() is deleted

@gergoabraham gergoabraham added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Nov 9, 2023
@gergoabraham gergoabraham self-assigned this Nov 9, 2023
@gergoabraham gergoabraham requested a review from a team as a code owner November 9, 2023 17:07
@gergoabraham gergoabraham requested review from pzl and joeypoon November 9, 2023 17:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@gergoabraham gergoabraham requested review from dasansol92 and tomsonpl and removed request for joeypoon and pzl November 9, 2023 17:07
@gergoabraham
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @gergoabraham

Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks for doing this :)

@gergoabraham gergoabraham merged commit e3f339c into elastic:main Nov 10, 2023
27 checks passed
@gergoabraham gergoabraham deleted the enable-tabs-in-policy-details-test-against-serverless branch November 10, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants