-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Defend Workflows] Enable Artifacts cy tests against serverless #170977
Merged
gergoabraham
merged 6 commits into
elastic:main
from
gergoabraham:enable-tabs-in-policy-details-test-against-serverless
Nov 10, 2023
Merged
[Defend Workflows] Enable Artifacts cy tests against serverless #170977
gergoabraham
merged 6 commits into
elastic:main
from
gergoabraham:enable-tabs-in-policy-details-test-against-serverless
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergoabraham
added
release_note:skip
Skip the PR/issue when compiling release notes
backport:skip
This commit does not require backporting
Team:Defend Workflows
“EDR Workflows” sub-team of Security Solution
labels
Nov 9, 2023
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
gergoabraham
requested review from
dasansol92 and
tomsonpl
and removed request for
joeypoon and
pzl
November 9, 2023 17:07
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
tomsonpl
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 thanks for doing this :)
gergoabraham
deleted the
enable-tabs-in-policy-details-test-against-serverless
branch
November 10, 2023 13:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:Defend Workflows
“EDR Workflows” sub-team of Security Solution
v8.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enables Artifact tabs in Policy details and Artifacts cypress tests against serverless. Or at least the test cases that has
ALL
privilege (orNONE
for the Artifacts tests), because there are no such roles in serverless environment that have:Additionally,
@skipInServerless
tag is added,indexEndpointHosts()
to have mocked data,loadEndpointDataForEventFiltersIfNeeded()
is deleted