[Security Solution] Removing cy.session from Cypress tests

[MadameSheema]

Context

We are working to execute our Cypress tests in the second Quality Gate (QA environment, deployed projects on MKI). To do so we are mimicking the orchestration we currently have thanks to the parallel.ts script on our ESS and serverless FTR environment, where each spec file is executed in its own project and each spec file can set the PLI that needs to be executed.

As part of this effort, we are trying to make our Cypress tests more robust and reliable what means having several consecutive green executions on an MKI environment through the buildkite pipeline we are testing.

During our testing we started to find a sign-off/unauthorized issue in some of our tests.

We originally thought that the issue might be caused due to the project not being fully initialized, so we added a big delay after the project creation without success, as well as other safety guards around the project as waiting to be able to login in our application before starting with the tests.

After digging more into the code, we saw that we are using cy.session in our login. With that implemented, after the first login, we store the session and we reuse it when login is called again inside the spec file.

All the above failures we faced, happened in spec files with login on a beforeEach hook, so it seemed that reusing the session was not a good idea in these MKI environments. We deleted the method and the execution worked as expected

In this PR

In this PR we are removing the cy.session functionality from our login.

[elasticmachine]

Pinging @elastic/security-solution (Team: SecuritySolution)

[charlie-pichette]

👍🏼

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 20bcb56

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema