-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Unfriendly error message when creating an invalid exception (#168213) #170764
[Security Solution] Unfriendly error message when creating an invalid exception (#168213) #170764
Conversation
Pinging @elastic/security-solution (Team: SecuritySolution) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @e40pud |
Summary
Addresses #168213
With this PR we limit the length of the comments in exceptions to 30K characters. We took same approach as used in Cases. User will not be allowed to create/edit exception with the comment longer than 30K and validation error will be shown.
Right now if user tries to add a very long comment (above 32K characters) the server throws an exception due to the length limitation of the
keyword
type.After the fix, user will see a validation error on putting very long text as a comment