Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Unfriendly error message when creating an invalid exception (#168213) #170764

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

e40pud
Copy link
Contributor

@e40pud e40pud commented Nov 7, 2023

Summary

Addresses #168213

With this PR we limit the length of the comments in exceptions to 30K characters. We took same approach as used in Cases. User will not be allowed to create/edit exception with the comment longer than 30K and validation error will be shown.

Right now if user tries to add a very long comment (above 32K characters) the server throws an exception due to the length limitation of the keyword type.

After the fix, user will see a validation error on putting very long text as a comment

Screenshot 2023-11-07 at 16 47 10

@e40pud e40pud added release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Exceptions Security Solution Detection Rule Exceptions area ci:cloud-deploy Create or update a Cloud deployment Team:Detection Engine Security Solution Detection Engine Area labels Nov 7, 2023
@e40pud e40pud self-assigned this Nov 7, 2023
@e40pud e40pud requested review from a team as code owners November 7, 2023 15:54
@e40pud e40pud requested review from pzl, parkiino and dhurley14 November 7, 2023 15:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Copy link
Contributor

@dhurley14 dhurley14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@e40pud e40pud requested a review from a team as a code owner November 8, 2023 13:06
@e40pud e40pud removed the ci:cloud-deploy Create or update a Cloud deployment label Nov 8, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.0MB 13.0MB +937.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 65.0KB 65.1KB +43.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @e40pud

@e40pud e40pud merged commit d644c70 into elastic:main Nov 8, 2023
@e40pud e40pud deleted the security/bugfix/168213-long-comments branch November 8, 2023 21:16
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Rule Exceptions Security Solution Detection Rule Exceptions area release_note:fix Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants