Change indexed fields table to use EuiToolTip and display 10 rows by default #17074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
|
Can you post some screenshots of what's different? |
|
jen-huang
force-pushed
the
fix/table-page-size
branch
from
9354140 to
37bf5ca
Compare
💔 Build Failed |
|
I'm seeing an error when I pull this down and change the field type on the page.
|
Merged
jen-huang
force-pushed
the
fix/table-page-size
branch
from
37bf5ca to
06dc13d
Compare
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
|
@chrisronline Can you update dependencies and check again? Also, upgraded EUI to 0.0.26 instead of 0.0.25 as the newer release fixes some EuiSelect tests. |
|
I noticed something else here too. I'm guessing a CSS fix in EUI? Notice the gray background: It's not showing when the tooltip isn't active |
|
@jen-huang I just created a PR against your PR, jen-huang#1, that will fix the gray background bug found by @chrisronline.
|
fix gray background when tooltip opened
💚 Build Succeeded |
|
Are we doing this PR or @nreese? |
|
#17110 is merged |
|
@chrisronline @nreese Merged master to this PR. Now only changes are updating initial number of table rows. Ok to merge? |
💚 Build Succeeded |
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Mar 13, 2018
jen-huang
added a commit
that referenced
this pull request
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates EUI to 0.0.26 to use some cool new stuff.