[APM] Refactor internal es client

[sorenlouv]

Related #170031.

The internal Elasticsearch client in APM currently takes apmIndices as a required argument. This is due to legacy reasons and no longer needed and should therefore be removed.

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[kpatticha]

why do you need to pass the apmIndices here from the resources when you could load them from the apm-data-access-plugin ?

import { APMIndices } from '@kbn/apm-data-access-plugin/server';

[sorenlouv]

APMIndices (that you mention) is a type. apmIndices is a value (object) produced at runtime.
apmIndices is produced with:

const apmIndices = await plugins.apmDataAccess.setup.getApmIndices(
  coreContext.savedObjects.client
);

[elasticmachine]

Pinging @elastic/apm-ui (Team:APM)

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: a703ab7

Failed CI Steps

• Investigations - Security Solution Cypress Tests #3
• Defend Workflows Cypress Tests on Serverless #3
• APM Cypress Tests #1

Test Failures

• [job] [logs] Investigations - Security Solution Cypress Tests #3 / Ransomware Detection Alerts Ransomware in Timelines Renders ransomware entries in timelines table Renders ransomware entries in timelines table

Metrics [docs]

✅ unchanged

History

• 💛 Build #174481 was flaky 503d161
• 💔 Build #174059 failed aff71b5b646c696f9f958c1dfc6f303a2309e5a0
• 💔 Build #173777 failed fbc539d402d3e1d07a3abffb190b21f2e87b7d1e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream