Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Log Explorer] Add logic to display highlights in Flyout #170650

Merged
merged 16 commits into from
Nov 10, 2023
Merged

[Log Explorer] Add logic to display highlights in Flyout #170650

merged 16 commits into from
Nov 10, 2023

Conversation

achyutjhunjhunwala
Copy link
Contributor

@achyutjhunjhunwala achyutjhunjhunwala commented Nov 6, 2023 •
edited
Loading

Summary

Closes #169504

Highlights

What's pending

  • FTR Tests

@achyutjhunjhunwala achyutjhunjhunwala added the release_note:feature Makes this part of the condensed release notes label Nov 6, 2023
@achyutjhunjhunwala achyutjhunjhunwala requested a review from a team November 6, 2023 15:03
@achyutjhunjhunwala achyutjhunjhunwala self-assigned this Nov 6, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@tonyghiani tonyghiani self-requested a review November 6, 2023 16:10
@achyutjhunjhunwala achyutjhunjhunwala marked this pull request as ready for review November 7, 2023 14:16
@achyutjhunjhunwala achyutjhunjhunwala requested a review from a team as a code owner November 7, 2023 14:16
@achyutjhunjhunwala achyutjhunjhunwala changed the title [Logs Explorer] Add logic to display highlights in Flyout [Log Explorer] Add logic to display highlights in Flyout Nov 7, 2023
@tonyghiani
Copy link
Contributor

/oblt-deploy

tonyghiani
tonyghiani requested changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done overall, thanks for taking care of working on so many requirements 🙏
I left some notes on missing requirements or improvements we can bring in, let me know if you have any doubts, I'm happy to review them together!

x-pack/plugins/log_explorer/common/constants.ts Outdated Show resolved Hide resolved
x-pack/plugins/log_explorer/public/components/flyout_detail/flyout_highlights.tsx Outdated Show resolved Hide resolved
x-pack/plugins/log_explorer/public/components/flyout_detail/fylout_header.tsx Outdated Show resolved Hide resolved
.../plugins/log_explorer/public/components/flyout_detail/sub_components/highlight_container.tsx Show resolved Hide resolved
.../plugins/log_explorer/public/components/flyout_detail/sub_components/highlight_container.tsx Outdated Show resolved Hide resolved
x-pack/plugins/log_explorer/public/components/flyout_detail/sub_components/hover_action.tsx Show resolved Hide resolved
x-pack/plugins/log_explorer/public/components/flyout_detail/sub_components/highlight_field.tsx Show resolved Hide resolved
x-pack/plugins/log_explorer/public/components/flyout_detail/sub_components/hover_action.tsx Outdated Show resolved Hide resolved
x-pack/plugins/log_explorer/public/context/discover_actions/use_discover_action.ts Outdated Show resolved Hide resolved
x-pack/test/functional/apps/observability_log_explorer/flyout_highlights.ts Show resolved Hide resolved
@achyutjhunjhunwala
Copy link
Contributor Author

achyutjhunjhunwala commented Nov 9, 2023 •
edited
Loading

@tonyghiani All review comments have been address and the PR is open for review again.

Regarding the design with ellipsis, i had a discussion with @isaclfreire. In order to handle the Actions better, i am changing with the grid columns dynamically based on breakpoint.

Nov-09-2023 14-46-09

tonyghiani
tonyghiani approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this work 👍

@achyutjhunjhunwala achyutjhunjhunwala requested a review from a team as a code owner November 10, 2023 16:01
@achyutjhunjhunwala achyutjhunjhunwala enabled auto-merge (squash) November 10, 2023 16:06
delanni
delanni approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@delanni delanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 limits change

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
logExplorer 476 609 +133

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
logExplorer 200.3KB 367.0KB +166.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
logExplorer 37.6KB 38.3KB +738.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @achyutjhunjhunwala

@achyutjhunjhunwala achyutjhunjhunwala merged commit c62df52 into elastic:main Nov 10, 2023
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 10, 2023
@achyutjhunjhunwala achyutjhunjhunwala deleted the log-flyout-highlights branch November 10, 2023 18:38
@logeekal logeekal mentioned this pull request Nov 16, 2023
Closed
@gbamparop gbamparop added the Team:obs-ux-logs Observability Logs User Experience Team label Mar 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaclfreire isaclfreire isaclfreire left review comments

@tonyghiani tonyghiani tonyghiani approved these changes

@delanni delanni delanni approved these changes

Assignees

@achyutjhunjhunwala achyutjhunjhunwala

Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:obs-ux-logs Observability Logs User Experience Team v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Log Explorer] Log Flyout highlight sections
9 participants
@achyutjhunjhunwala @apmmachine @tonyghiani @kibana-ci @elasticmachine @delanni @isaclfreire @gbamparop @kibanamachine