Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiling] Use CO2 and Cost values provided by the ES Profiling APIs #170612

Merged
merged 30 commits into from
Dec 4, 2023
Merged

[Profiling] Use CO2 and Cost values provided by the ES Profiling APIs #170612

merged 30 commits into from
Dec 4, 2023

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Nov 6, 2023 •
edited
Loading

  • Removes old flamegraph code replacing it with the ES Flamegraph API
  • Creates new user settings
  • Adds a feature flag to use the kibana CO2/Cost calculations instead of the new version
  • Reads CO2 and Cost from /Stacktraces and /Flamegraph APIs

Where do we show the CO2 and Cost values?

  • Flamegraph toolip
  • Flamegraph Frame information flyout
  • Diff Flamegraph Summary
  • Functions table
  • Function information flyout
  • Diff Functions Summary

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v8.12.0 labels Nov 6, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cauemarcondes cauemarcondes changed the title [Profiling] Adding total duration to Stacktraces and profiling APIs [Profiling] Adding total duration to Stacktraces and flamegraph APIs Nov 6, 2023
rockdaboot
rockdaboot approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@rockdaboot rockdaboot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, tested.

@rockdaboot rockdaboot self-requested a review November 23, 2023 17:30
@cauemarcondes cauemarcondes marked this pull request as ready for review November 29, 2023 12:55
@cauemarcondes cauemarcondes requested review from a team as code owners November 29, 2023 12:55
shahzad31
shahzad31 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OBS UG MGMT CHANGES LGTM !!

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Nov 29, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@cauemarcondes cauemarcondes changed the title [Profiling] Adding total duration to Stacktraces and flamegraph APIs [Profiling] Use CO2 and Cost values provided by the ES Profiling APIs Nov 29, 2023
@cauemarcondes cauemarcondes requested a review from a team as a code owner November 29, 2023 13:57
mdbirnstiehl
mdbirnstiehl approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rockdaboot
rockdaboot approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@rockdaboot rockdaboot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

MiriamAparicio
MiriamAparicio reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/profiling-utils 30 51 +21
observability 572 596 +24
total +45

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 369.2KB 374.8KB +5.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 100.0KB 100.5KB +432.0B
profiling 19.2KB 19.6KB +443.0B
total +875.0B
Unknown metric groups

API count

id before after diff
@kbn/profiling-utils 173 169 -4
observability 581 605 +24
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes enabled auto-merge (squash) December 1, 2023 16:21
@alaudazzi alaudazzi removed their request for review December 1, 2023 16:23
@cauemarcondes cauemarcondes merged commit 7470d21 into elastic:main Dec 4, 2023
36 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 4, 2023
@bmorelli25 bmorelli25 mentioned this pull request Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdbirnstiehl mdbirnstiehl mdbirnstiehl approved these changes

@MiriamAparicio MiriamAparicio MiriamAparicio approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@rockdaboot rockdaboot rockdaboot approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:obs-ux-management Observability Management User Experience Team v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@cauemarcondes @apmmachine @elasticmachine @kibana-ci @pgayvallet @rockdaboot @shahzad31 @MiriamAparicio @mdbirnstiehl @kibanamachine