Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix: #17037 managementChangeIndexModal out of Viewport #17043

Merged
merged 1 commit into from
Mar 9, 2018
Merged

BugFix: #17037 managementChangeIndexModal out of Viewport #17043

merged 1 commit into from
Mar 9, 2018

Conversation

varunsharma27
Copy link
Contributor

Fixes #17037

@elasticmachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@chrisronline chrisronline self-requested a review March 8, 2018 18:13
@chrisronline
Copy link
Contributor

jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@varunsharma27 varunsharma27 changed the title BugFix: #17037 managementChangeIndexModal managementChangeIndexModal BugFix: #17037 managementChangeIndexModal out of Viewport Mar 9, 2018
@chrisronline
Copy link
Contributor

This looks great!

For more detail, here is what it is now:
screen shot 2018-03-09 at 9 35 45 am

And what it is after this change:
screen shot 2018-03-09 at 9 35 52 am

@chrisronline
Copy link
Contributor

LGTM! Thanks @varundbest for this great contribution!

@chrisronline chrisronline merged commit 7682d64 into elastic:master Mar 9, 2018
@chrisronline chrisronline mentioned this pull request Mar 9, 2018
Merged
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Mar 9, 2018
@varunsharma27 @chrisronline
BugFix: elastic#17037 managementChangeIndexModal managementChangeInde…
72ae7df 
…xModal (elastic#17043)
@chrisronline chrisronline mentioned this pull request Mar 9, 2018
Closed
chrisronline added a commit that referenced this pull request Mar 9, 2018
@chrisronline
BugFix: #17037 managementChangeIndexModal managementChangeIndexModal (#…
d27a2a4 
…17043) (#17066)
@chrisronline
Copy link
Contributor

Backport:

6.x: d27a2a4

@varunsharma27 varunsharma27 deleted the issue-17037-managementChangeIndexModal branch March 15, 2018 09:30
@chrisronline chrisronline mentioned this pull request Mar 28, 2018
Closed
@jinleileiking
Copy link

jinleileiking commented Mar 29, 2018 •
edited
Loading

I need this feature right now.
But I modify the main.less, restart kibana, not work.
show modify the css file.My fault

@varunsharma27
Copy link
Contributor Author

@jinleileiking Delete bundles folder inside Optimize after making the changes for them to take effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisronline chrisronline Awaiting requested review from chrisronline

Assignees
No one assigned
Labels
v6.3.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@varunsharma27 @elasticmachine @chrisronline @jinleileiking