-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cases] Fix filtering e2e flaky tests #170383
Conversation
Pinging @elastic/response-ops (Team:ResponseOps) |
Pinging @elastic/response-ops-cases (Feature:Cases) |
@@ -85,10 +84,13 @@ export function CasesTableServiceProvider( | |||
}, | |||
|
|||
async validateCasesTableHasNthRows(nrRows: number) { | |||
await retry.tryForTime(3000, async () => { | |||
await retry.waitFor(`the cases table to have ${nrRows} cases`, async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why will waitFor
be different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question! I should put a comment. I noticed that the waitFor
has bigger waiting times (20sec) and also the ability to provide a message makes it easier to debug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright! I was ust wondering if there was something sneaky in the way things are done underneath by waitFor
vs tryForTime
.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @cnasikas |
(cherry picked from commit 8ced30d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.11`: - [[Cases] Fix filtering e2e flaky tests (#170383)](#170383) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Christos Nasikas","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-02T18:01:15Z","message":"[Cases] Fix filtering e2e flaky tests (#170383)","sha":"8ced30dcdba455936cb8bdfc3a4125228ee141da","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Cases","v8.12.0","v8.11.1"],"number":170383,"url":"https://github.com/elastic/kibana/pull/170383","mergeCommit":{"message":"[Cases] Fix filtering e2e flaky tests (#170383)","sha":"8ced30dcdba455936cb8bdfc3a4125228ee141da"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170383","number":170383,"mergeCommit":{"message":"[Cases] Fix filtering e2e flaky tests (#170383)","sha":"8ced30dcdba455936cb8bdfc3a4125228ee141da"}},{"branch":"8.11","label":"v8.11.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Christos Nasikas <[email protected]>
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Fixes: #152928, #152925, #152958
Flaky test runners:
Checklist
Delete any items that are not applicable to this PR.
For maintainers