[RAM][Maintenance Window] Fix maintenance window category ID edit UI not initializing correctly. #170352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaweiWu
added
bug
|
Pinging @elastic/response-ops (Team:ResponseOps) |
XavierM
approved these changes
Nov 1, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 2, 2023
…not initializing correctly. (elastic#170352) ## Summary Fixed a bug with the MW category ID selection feature where if a MW had it's category IDs changed, when attempting to edit this MW, the category IDs would fail to initialize. Steps to test: 1. Create a maintenance window with only 2 categories selected (o11y, management) 2. Edit the maintenance window 3. Assert that the categories initialize correctly (o11y and management checkboxes are checked) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit ea1451e)
kibanamachine
added a commit
that referenced
this pull request
Nov 2, 2023
…dit UI not initializing correctly. (#170352) (#170377) # Backport This will backport the following commits from `main` to `8.11`: - [[RAM][Maintenance Window] Fix maintenance window category ID edit UI not initializing correctly. (#170352)](#170352) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jiawei Wu","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-02T03:55:02Z","message":"[RAM][Maintenance Window] Fix maintenance window category ID edit UI not initializing correctly. (#170352)\n\n## Summary\r\nFixed a bug with the MW category ID selection feature where if a MW had\r\nit's category IDs changed, when attempting to edit this MW, the category\r\nIDs would fail to initialize.\r\n\r\nSteps to test:\r\n1. Create a maintenance window with only 2 categories selected (o11y,\r\nmanagement)\r\n2. Edit the maintenance window\r\n3. Assert that the categories initialize correctly (o11y and management\r\ncheckboxes are checked)\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ea1451e14c5543ed40a8448a80556c91173815e5","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","Feature:Alerting/RulesManagement","v8.11.0","v8.12.0"],"number":170352,"url":"https://github.com/elastic/kibana/pull/170352","mergeCommit":{"message":"[RAM][Maintenance Window] Fix maintenance window category ID edit UI not initializing correctly. (#170352)\n\n## Summary\r\nFixed a bug with the MW category ID selection feature where if a MW had\r\nit's category IDs changed, when attempting to edit this MW, the category\r\nIDs would fail to initialize.\r\n\r\nSteps to test:\r\n1. Create a maintenance window with only 2 categories selected (o11y,\r\nmanagement)\r\n2. Edit the maintenance window\r\n3. Assert that the categories initialize correctly (o11y and management\r\ncheckboxes are checked)\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ea1451e14c5543ed40a8448a80556c91173815e5"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170352","number":170352,"mergeCommit":{"message":"[RAM][Maintenance Window] Fix maintenance window category ID edit UI not initializing correctly. (#170352)\n\n## Summary\r\nFixed a bug with the MW category ID selection feature where if a MW had\r\nit's category IDs changed, when attempting to edit this MW, the category\r\nIDs would fail to initialize.\r\n\r\nSteps to test:\r\n1. Create a maintenance window with only 2 categories selected (o11y,\r\nmanagement)\r\n2. Edit the maintenance window\r\n3. Assert that the categories initialize correctly (o11y and management\r\ncheckboxes are checked)\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ea1451e14c5543ed40a8448a80556c91173815e5"}}]}] BACKPORT--> Co-authored-by: Jiawei Wu <[email protected]>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Nov 6, 2023
…not initializing correctly. (elastic#170352) ## Summary Fixed a bug with the MW category ID selection feature where if a MW had it's category IDs changed, when attempting to edit this MW, the category IDs would fail to initialize. Steps to test: 1. Create a maintenance window with only 2 categories selected (o11y, management) 2. Edit the maintenance window 3. Assert that the categories initialize correctly (o11y and management checkboxes are checked) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a bug with the MW category ID selection feature where if a MW had it's category IDs changed, when attempting to edit this MW, the category IDs would fail to initialize.
Steps to test:
Checklist