[application_deep_links] Unify / improve navigation between apps #170228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsoldevila
added
the
Team:Core
gsoldevila
commented
Oct 31, 2023
| }); | ||
|
|
||
| it('should navigate to Home when navlink is clicked inside the defined category group', async () => { | ||
| await appsMenu.clickLink('DL Home', { category: 'securitySolution' }); |
There was a problem hiding this comment.
This is the previous/old navigation logic that should have been removed.
I believe this is the source of the new / reoccurring flakiness.
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-core (Team:Core) |
afharo
approved these changes
Oct 31, 2023
Comment on lines
+22
to
+28
| const clickAppLink = async (app: string) => { | ||
| const appLink = `dlNav${app}`; | ||
| if (!(await testSubjects.exists(appLink))) { | ||
| log.debug(`App ${app} not found on side nav`); | ||
| } | ||
| await testSubjects.click(appLink); | ||
| }; |
There was a problem hiding this comment.
Super cool! I'd be great to have this in the helpers.
There was a problem hiding this comment.
This one is custom to the deep links apps (note the dlNav), but perhaps we can generalise it somehow.
In fact, I have a few more improvements in the pipes for other tests in the test_suites/core_plugins. Stay tunned!
gsoldevila
added
the
release_note:skip
kibanamachine
added
v8.12.0
backport:skip
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Nov 6, 2023
…stic#170228) ## Summary Attempt at fixing elastic#166893 PR [elastic#168741](elastic#168741) forgot to update one of the tests to **exclusively** use `navigateToAppLinks`. Thus, the impacted test had a duplicated navigation logic. This PR: * removes that unintended call (this should hopefully fix flakiness). * simplifies and unifies test logic, improving readability. Flaky test runner pipeline - 100x 🟢 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3840
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Attempt at fixing #166893
PR #168741 forgot to update one of the tests to exclusively use
navigateToAppLinks.Thus, the impacted test had a duplicated navigation logic.
This PR:
Flaky test runner pipeline - 100x 🟢
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3840