Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Don't overwrite logs-* and metrics-* data views on every integration install #170188

Merged

Conversation

kpollich
Copy link
Member

@kpollich kpollich commented Oct 30, 2023

Replaces #169409

  • Import data views (index patterns) separately with overwrite: false

@kpollich kpollich self-assigned this Oct 30, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kpollich
Copy link
Member Author

@elasticmachine merge upstream

@kpollich kpollich marked this pull request as ready for review October 31, 2023 15:34
@kpollich kpollich requested a review from a team as a code owner October 31, 2023 15:34
@kpollich kpollich added release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team labels Oct 31, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kpollich kpollich changed the title [Fleet] Fix data view scripted/runtime fields being overwritten on integration install [Fleet] Don't overwrite logs-* and metrics-* data views on every integration install Oct 31, 2023
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpollich
Copy link
Member Author

kpollich commented Nov 1, 2023

I'm going to try and write an integration test for this sometime today before merging.

@kpollich
Copy link
Member Author

kpollich commented Nov 1, 2023

@elasticmachine merge upstream

@kpollich kpollich enabled auto-merge (squash) November 1, 2023 17:55
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #4 / Save Timeline Prompts "before each" hook for "Changed and unsaved timeline should NOT prompt when user navigates from the page where timeline is disabled" "before each" hook for "Changed and unsaved timeline should NOT prompt when user navigates from the page where timeline is disabled"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit 9051d76 into elastic:main Nov 1, 2023
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 1, 2023
delanni pushed a commit to delanni/kibana that referenced this pull request Nov 6, 2023
…integration install (elastic#170188)

Replaces elastic#169409

- Import data views (index patterns) separately with `overwrite: false`

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants