[Security Solution][API testing] Move and restructures rule preview test and actions legacy utils #170147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WafaaNasr
added
release_note:skip
…WafaaNasr/kibana into move-structure-rule_preview-api
…ructure-rule_preview-api
WafaaNasr
changed the title
…ructure-rule_preview-api
…run in Serverless
WafaaNasr
changed the title
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @WafaaNasr |
yctercero
approved these changes
Nov 1, 2023
kibanamachine
added
v8.12.0
backport:skip
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Nov 6, 2023
…est and actions legacy utils (elastic#170147) ## Summary - Following the initial work in this elastic#166755 - Addresses part of elastic#151902 for rule preview https://docs.google.com/document/d/1CRFfDWMzw3ob03euWIvT4-IoiLXjoiPWI8mTBqP4Zks/edit - Remove the `skipInQA` tag from `Migrations` actions test since it runs only in ESS env. ### Moved files from `detection_engine_api_integrations` to `security_solution_api_integration` - utils (Moved and references are updated): - './get_legacy_action_notifications_so_by_id'; - './get_legacy_actions_so_by_id'; - './get_simple_preview_rule'; - './get_simple_rule_output_with_web_hook_action'; - './get_simple_rule_preview_output'; - Group1: - `preview_rules` moved under the `rule_creation` folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://docs.google.com/document/d/1CRFfDWMzw3ob03euWIvT4-IoiLXjoiPWI8mTBqP4Zks/edit
skipInQAtag fromMigrationsactions test since it runs only in ESS env.Moved files from
detection_engine_api_integrationstosecurity_solution_api_integrationutils (Moved and references are updated):
Group1:
preview_rulesmoved under therule_creationfolder